Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html/minifier): small merge fix #6443

Merged
merged 4 commits into from
Nov 16, 2022
Merged

fix(html/minifier): small merge fix #6443

merged 4 commits into from
Nov 16, 2022
+89 −25

Conversation

alexander-akait
Copy link
Contributor

Description:

Small fix

BREAKING CHANGE:

No

Related issue (if exists):

No

kdy1
kdy1 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_minifier

@kdy1 kdy1 added this to the Planned milestone Nov 15, 2022
kdy1
kdy1 requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's merge conflict

@alexander-akait alexander-akait force-pushed the fix-small-bug-with-empty-metadata branch from 491b6e4 to ada3884 Compare November 15, 2022 14:46
@alexander-akait
Copy link
Contributor Author

@kdy1 Fixed 👍

@kdy1 kdy1 enabled auto-merge (squash) November 15, 2022 22:53
swc-bot
swc-bot reviewed Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 1dfd8ce into swc-project:main Nov 16, 2022
@alexander-akait alexander-akait deleted the fix-small-bug-with-empty-metadata branch November 16, 2022 03:34
@kdy1 kdy1 modified the milestones: Planned, v1.3.18 Nov 16, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot