fix(ecma/parser): regexp parsing #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Nov 18, 2022
alexander-akait
commented
Nov 18, 2022
alexander-akait
commented
Nov 18, 2022
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| x Unexpected eof | |||
| x Unterminated regexp literal | |||
| ,-[$DIR/tests/test262-parser/fail/095bea002b10b8e1.js:1:1] | |||
| 1 | foo[/42 | |||
There was a problem hiding this comment.
Better error
|
@kdy1 Ready for review |
swc-bot
reviewed
Nov 18, 2022
kdy1
added a commit
to kdy1/swc
that referenced
this pull request
Nov 19, 2022
This reverts commit 3e702b9.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix regexp parsing
BREAKING CHANGE:
Potential yes due new method
Related issue (if exists):
fixes #6322
fixes #6323