-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/minifier): Use unsafe option for arrow => method #6521
Conversation
arrows
arrows
if eval
exists
arrows
if eval
existsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_minifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really fix either bug? It seems like we're just avoiding it because we're not converting to method shorthand anymore, but the real bug is that the compresser is omitting the {}
enclosing object?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, crawling through the bugs it's being caused because they're doing string concatenation of functions, which is inherently buggy if we're minifying it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
Description:
Related issue:
Investigation
This is caused by
arrows
, and seems like a same issue as #6507prints
foo(){}
.