Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xml/parser): refactor element parsing #6557

Merged
merged 11 commits into from
Dec 1, 2022

Conversation

alexander-akait
Copy link
Contributor

Description:

Simplify logic and be more stricky for XML

BREAKING CHANGE:

No

Related issue (if exists):

No

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
marco-ippolito Marco Ippolito

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso

Verified

This commit was signed with the committer’s verified signature.
mcollina Matteo Collina

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
aduh95 Antoine du Hamel
@alexander-akait alexander-akait changed the title Xml element parsing refactor fix(xml/parser): refactor element parsing Nov 30, 2022

Verified

This commit was signed with the committer’s verified signature.
RafaelGSS Rafael Gonzaga

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
@kdy1 kdy1 added this to the Planned milestone Dec 1, 2022
@kdy1 kdy1 self-assigned this Dec 1, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_xml_ast --breaking

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kdy1 kdy1 enabled auto-merge (squash) December 1, 2022 02:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 85a03e7 into swc-project:main Dec 1, 2022
@alexander-akait alexander-akait deleted the xml-element-parsing-refactor branch December 1, 2022 14:39
@kdy1 kdy1 modified the milestones: Planned, v1.3.22 Dec 9, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants