chore: 🤖 remove unnecessary code

[IWANABETHATGUY]

Description:

1. remove unnecessary code, this function is invoked but did nothing if it return true,
   also

   swc/crates/swc_ecma_minifier/src/metadata/mod.rs

   Lines 350 to 444 in 9a20ddf

   	impl VisitMut for IdentCollector {
   	noop_visit_mut_type!();
   	fn visit_mut_catch_clause(&mut self, c: &mut CatchClause) {
   	let old = self.is_pat_decl;
   	self.is_pat_decl = true;
   	c.param.visit_mut_children_with(self);
   	self.is_pat_decl = old;
   	self.is_pat_decl = false;
   	c.body.visit_mut_with(self);
   	self.is_pat_decl = old;
   	}
   	fn visit_mut_class_decl(&mut self, e: &mut ClassDecl) {
   	if self.for_binding {
   	e.ident.visit_mut_with(self);
   	}
   	e.class.visit_mut_with(self);
   	}
   	fn visit_mut_class_expr(&mut self, e: &mut ClassExpr) {
   	e.class.visit_mut_with(self);
   	}
   	fn visit_mut_expr(&mut self, e: &mut Expr) {
   	match e {
   	Expr::Ident(..) if self.for_binding => {}
   	_ => {
   	e.visit_mut_children_with(self);
   	}
   	}
   	}
   	fn visit_mut_fn_decl(&mut self, e: &mut FnDecl) {
   	if self.for_binding {
   	e.ident.visit_mut_with(self);
   	}
   	e.function.visit_mut_with(self);
   	}
   	fn visit_mut_fn_expr(&mut self, e: &mut FnExpr) {
   	if self.for_binding {
   	e.ident.visit_mut_with(self);
   	}
   	e.function.visit_mut_with(self);
   	}
   	fn visit_mut_ident(&mut self, i: &mut Ident) {
   	self.add(&*i);
   	}
   	fn visit_mut_labeled_stmt(&mut self, s: &mut LabeledStmt) {
   	s.body.visit_mut_with(self);
   	}
   	fn visit_mut_param(&mut self, p: &mut Param) {
   	let old = self.is_pat_decl;
   	self.is_pat_decl = true;
   	p.visit_mut_children_with(self);
   	self.is_pat_decl = old;
   	}
   	fn visit_mut_pat(&mut self, p: &mut Pat) {
   	match p {
   	Pat::Ident(..) if self.for_binding && !self.is_pat_decl => {}
   	_ => {
   	p.visit_mut_children_with(self);
   	}
   	}
   	}
   	fn visit_mut_prop_name(&mut self, p: &mut PropName) {
   	if let PropName::Computed(..) = p {
   	p.visit_mut_children_with(self);
   	}
   	}
   	fn visit_mut_var_declarator(&mut self, d: &mut VarDeclarator) {
   	let old = self.is_pat_decl;
   	self.is_pat_decl = true;
   	d.name.visit_mut_with(self);
   	self.is_pat_decl = false;
   	d.init.visit_mut_with(self);
   	self.is_pat_decl = old;
   	}
   	}

   , Although this visitor visit &mut Ast node, but we could see that it does't modified ast node, over all, remove
   those code is safe.
2. This pr would improve a little performance.

BREAKING CHANGE:

Related issue (if exists):

[IWANABETHATGUY]

@kdy1 , the benchmark CI is broken due to network issue, but I don't have permission to retry it, would you mind helping with rerunning it?

[kdy1]

swc-bump:

• swc_ecma_minifier