Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(css/parser): Reduce clones and allocations #6585

Merged
merged 8 commits into from Dec 6, 2022
Merged

perf(css/parser): Reduce clones and allocations #6585

merged 8 commits into from Dec 6, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 6, 2022 •
edited

Description:

  • We use (BytePos, BytePos) instead of Box<Span>.
  • We use Cow for Input.

Related issue (if exists):

image

@kdy1 kdy1 added this to the Planned milestone Dec 6, 2022
@kdy1 kdy1 self-assigned this Dec 6, 2022
@kdy1 kdy1 marked this pull request as ready for review December 6, 2022 13:45
@kdy1 kdy1 enabled auto-merge (squash) December 6, 2022 13:45
kdy1
kdy1 commented Dec 6, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset ci

swc-bump:

  • swc_css_parser

@kdy1 kdy1 merged commit 6479670 into swc-project:main Dec 6, 2022
@kdy1 kdy1 deleted the parser branch December 6, 2022 14:27
@kdy1 kdy1 modified the milestones: Planned, v1.3.22 Dec 9, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.22
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @alexander-akait