Extract the ES usage analyzer from the ES minifier crate #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbinnssmith
previously approved these changes
Dec 6, 2022
kdy1
reviewed
Dec 7, 2022
| @@ -234,7 +234,7 @@ enum RecursiveUsage { | |||
|
|
|||
| /// Analyzed info of a whole program we are working on. | |||
| #[derive(Debug, Default)] | |||
| pub(crate) struct ProgramData { | |||
| pub struct ProgramData { | |||
There was a problem hiding this comment.
Are you going to use this type directly?
There was a problem hiding this comment.
I prefer storing this type in swc_ecma_minifier, to reduce breaking changes.
There was a problem hiding this comment.
The current definition of UsageAnalyzer depends on it: UsageAnalyzer<S = ProgramData>. But I agree this makes more sense to live in swc_ecma_minifier for now so I'll move it and remove the default type.
From what I can tell the only breaking change is the marks::Marks type changing crates, and we can always re-export it from swc_ecma_minifier.
There was a problem hiding this comment.
Yeah, I think it's fine. Thank you!
kdy1
reviewed
Dec 7, 2022
kdy1
previously approved these changes
Dec 7, 2022
swc-bot
reviewed
Dec 7, 2022
auto-merge was automatically disabled
December 7, 2022 10:35
Head branch was pushed to by a user without write access
alexkirsz
force-pushed
the
alexkirsz/extract-usage-analyzer
branch
from
06e071f
to
7aa4e29
Compare
kdy1
approved these changes
Dec 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR extracts the EcmaScript usage analyzer from the ES minifier crate into its own crate, to make it reusable by third parties. Notably, we plan on using this in Turbopack to implement tree shaking.
BREAKING CHANGE:
The
swc_ecma_minifier::marks::Markstype is now exported fromswc_ecma_usage_analyzer::marks::Marksinstead. It might make sense to also re-export it from theswc_ecma_minifiercrate.Related issue (if exists):
Fixes WEB-269