Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(html/parser): improve #6590

Merged
merged 8 commits into from Dec 7, 2022
Merged

perf(html/parser): improve #6590

merged 8 commits into from Dec 7, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Dec 6, 2022 •
edited

Description:

  • Also small bug fix for swc_html_codegen

perf:

html/parser_document/css_2021_spec                                                                            
                        time:   [23.669 ms 23.763 ms 23.871 ms]
                        change: [-4.2093% -3.4579% -2.7503%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe

Benchmarking html/parser_document/github_com_17_05_2022: Collecting 100 samples in estimated 5.1213 s (600 iterati                                                                                                                  html/parser_document/github_com_17_05_2022                        
                        time:   [8.2812 ms 8.3389 ms 8.4115 ms]
                        change: [-11.642% -10.727% -9.6697%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  5 (5.00%) high mild
  5 (5.00%) high severe

Benchmarking html/parser_document/stackoverflow_com_17_05_2022: Collecting 100 samples in estimated 5.1562 s (700                                                                                                                   html/parser_document/stackoverflow_com_17_05_2022                        
                        time:   [7.2896 ms 7.3277 ms 7.3745 ms]
                        change: [-10.511% -9.7884% -9.0822%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  6 (6.00%) high mild
  5 (5.00%) high severe

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 enabled auto-merge (squash) December 7, 2022 01:06
kdy1
kdy1 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_ast

@kdy1 kdy1 added this to the Planned milestone Dec 7, 2022
swc-bot
swc-bot reviewed Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d6e9613 into swc-project:main Dec 7, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.22 Dec 9, 2022
@alexander-akait alexander-akait deleted the perf-html-parser branch December 9, 2022 09:51
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot