Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/parser): avoid skipping extra whitespaces #6592

Merged
merged 2 commits into from Dec 7, 2022
Merged

fix(css/parser): avoid skipping extra whitespaces #6592

merged 2 commits into from Dec 7, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

Avoid skipping whitespaces in [/(/{ because:

  • it is invalid, whitespaces can allowed and can be disallowed based on context, we can't apply this logic for any CSS context
  • we already skip whitespaces where it is necessary (no failed tests)
  • avoid extra actions

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 assigned kdy1 and unassigned kdy1 Dec 7, 2022
@kdy1 kdy1 added this to the Planned milestone Dec 7, 2022
@kdy1 kdy1 enabled auto-merge (squash) December 7, 2022 03:11
kdy1
kdy1 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_parser

swc-bot
swc-bot reviewed Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d8936ad into swc-project:main Dec 7, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.22 Dec 9, 2022
@alexander-akait alexander-akait deleted the fix-avoid-extra-skipping-whitespaces branch December 9, 2022 09:52
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot