Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(css/parser): Don't allocate for comparisons #6593

Merged
merged 36 commits into from Dec 7, 2022
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 7, 2022

Description:

We don't need to allocate to compare.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Dec 7, 2022
@kdy1 kdy1 self-assigned this Dec 7, 2022
@kdy1 kdy1 changed the title perf(css/parser): Use eq_ignore_ascii_case instead of to_ascii_lowercase perf(css/parser): Don't allocate for comparisons Dec 7, 2022
@kdy1 kdy1 marked this pull request as ready for review December 7, 2022 08:07
kodiakhq[bot]
kodiakhq bot previously approved these changes Dec 7, 2022
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_ast

@kdy1 kdy1 merged commit 08b6eab into swc-project:main Dec 7, 2022
@kdy1 kdy1 deleted the again branch December 7, 2022 09:27
@kdy1 kdy1 modified the milestones: Planned, v1.3.22 Dec 9, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants