Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/minifier): convert to and from initial #6613

Merged
merged 10 commits into from Dec 12, 2022
Merged

feat(css/minifier): convert to and from initial #6613

merged 10 commits into from Dec 12, 2022

Conversation

alexander-akait
Copy link
Collaborator

Description:

port of https://github.com/cssnano/cssnano/tree/master/packages/postcss-reduce-initial

BREAKING CHANGE:

Yes, due AST changes

Related issue (if exists):

No

@alexander-akait alexander-akait changed the title Feat css minifier port initial feat(css/minifier): convert to and from initial Dec 9, 2022
kdy1
kdy1 requested changes Dec 10, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
eq_ignore_ascii_case is faster than comparison after to_ascii_lowercase

crates/swc_css_minifier/src/compressor/declaration.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Dec 10, 2022
kdy1
kdy1 reviewed Dec 10, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms
  • swc_css_ast --breaking

@kdy1 kdy1 self-assigned this Dec 10, 2022
@alexander-akait
Copy link
Collaborator Author

WIP on perf 👍

@alexander-akait
Copy link
Collaborator Author

@kdy1 Ready for review

kdy1
kdy1 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 enabled auto-merge (squash) December 12, 2022 01:56
swc-bot
swc-bot reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit cb49fa6 into swc-project:main Dec 12, 2022
@alexander-akait alexander-akait deleted the feat-css-minifier-port-initial branch December 12, 2022 12:24
@kdy1 kdy1 modified the milestones: Planned, v1.3.23 Dec 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot