Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(html/codegen): improve perf #6622

Merged
merged 4 commits into from Dec 12, 2022
Merged

feat(html/codegen): improve perf #6622

merged 4 commits into from Dec 12, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Dec 11, 2022 •
edited

Description:

Performance:

html/minify/document/css_spec                                                                           
                        time:   [38.763 ms 38.821 ms 38.915 ms]
                        change: [-4.1127% -3.6128% -3.0759%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
html/minify/document/github                                                                           
                        time:   [16.572 ms 16.694 ms 16.862 ms]
                        change: [-3.3237% -2.7138% -1.7989%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
html/minify/document/stackoverflow                                                                           
                        time:   [14.690 ms 15.023 ms 15.315 ms]
                        change: [-3.6187% -2.1485% -0.4165%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 10 measurements (10.00%)

BREAKING CHANGE:

No

Related issue (if exists):

No

@alexander-akait alexander-akait changed the title Feat perf codegen feat(html/codegen): improve perf Dec 11, 2022
kdy1
kdy1 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_html_codegen

@kdy1 kdy1 enabled auto-merge (squash) December 12, 2022 01:59
@kdy1 kdy1 added this to the Planned milestone Dec 12, 2022
@kdy1 kdy1 self-assigned this Dec 12, 2022
swc-bot
swc-bot reviewed Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit bfdafdb into swc-project:main Dec 12, 2022
@alexander-akait alexander-akait deleted the feat-perf-codegen branch December 12, 2022 12:23
@kdy1 kdy1 modified the milestones: Planned, v1.3.23 Dec 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot