Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(html/minifier): improve #6623

Merged
merged 4 commits into from Dec 13, 2022
Merged

perf(html/minifier): improve #6623

merged 4 commits into from Dec 13, 2022

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Dec 12, 2022 •
edited

Description:

Perfomance

html/minify/document/css_spec                                                                           
                        time:   [43.512 ms 43.916 ms 44.256 ms]
                        change: [-3.1141% -4.3358% -1.5325%] (p = 0.00 < 0.05)
                        Performance has improved.
html/minify/document/github                                                                           
                        time:   [18.073 ms 18.185 ms 18.287 ms]
                        change: [-6.1095% -5.2255% -4.3092%] (p = 0.00 < 0.05)
                        Performance has improved.
html/minify/document/stackoverflow                                                                           
                        time:   [16.283 ms 16.507 ms 16.666 ms]
                        change: [-2.5504% -1.1837% +0.1196%] (p = 0.14 > 0.05)
                        No change in performance detected.

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 added this to the Planned milestone Dec 12, 2022
@kdy1 kdy1 self-assigned this Dec 12, 2022
kdy1
kdy1 previously approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms
  • swc_html_minifier

@kdy1 kdy1 enabled auto-merge (squash) December 12, 2022 02:07
@alexander-akait
Copy link
Collaborator Author

@kdy Rebased

kdy1
kdy1 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms
  • swc_html_minifier

@kdy1 kdy1 merged commit 7d3aa66 into swc-project:main Dec 13, 2022
@alexander-akait alexander-akait deleted the perf-html-minifier branch December 13, 2022 10:19
@kdy1 kdy1 modified the milestones: Planned, v1.3.23 Dec 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.23
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexander-akait @kdy1