Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/typescript): Support const modifier on type parameters #6672

Merged
merged 4 commits into from Jan 10, 2023
Merged

feat(es/typescript): Support const modifier on type parameters #6672

merged 4 commits into from Jan 10, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 self-assigned this Dec 17, 2022
@magic-akari magic-akari marked this pull request as ready for review January 9, 2023 09:55
@kdy1 kdy1 changed the title feat(es/ts): Support const modifier on type parameters feat(es/typescript): Support const modifier on type parameters Jan 10, 2023
kdy1
kdy1 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_ast --breaking

@kdy1 kdy1 enabled auto-merge (squash) January 10, 2023 02:15
swc-bot
swc-bot reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 019cf37 into swc-project:main Jan 10, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.26 Jan 11, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 10, 2023
@magic-akari magic-akari deleted the feat/const-modifier-type-param branch March 10, 2023 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.26
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magic-akari @kdy1 @swc-bot