refactor(css/codegen): do not use raw
#6674
Merged
+4,015
−3,238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
changed the title
raw
kdy1
reviewed
Dec 19, 2022
alexander-akait
force-pushed
the
refactor-do-not-use-raw-in-codegen
branch
from
02ce308 to
fc1cea0
Compare
|
@kdy1 Rebased too |
kdy1
previously approved these changes
Dec 20, 2022
alexander-akait
force-pushed
the
refactor-do-not-use-raw-in-codegen
branch
2 times, most recently
from
73ea12d to
1aed07a
Compare
|
@kdy1 Rebased too |
alexander-akait
force-pushed
the
refactor-do-not-use-raw-in-codegen
branch
from
1aed07a to
7f8941f
Compare
|
@kdy1 Fixed too 👍 |
kdy1
approved these changes
Dec 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor codegen and do not use
raw, also:e\32pxdimension (we need to escape as in spec)"inStrelement()function (before we parse it as hash, now as id selector)BREAKING CHANGE:
Yes, we don't use
rawin codegen, except printing tokens, so if you want to inject something non standard, you should useListOfComponentValueswithPreservedTokenRelated issue (if exists):
No