Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/prefixer): page break #6693

Merged
merged 4 commits into from
Dec 21, 2022
Merged

feat(css/prefixer): page break #6693

merged 4 commits into from
Dec 21, 2022
+468 −226

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Dec 20, 2022 •
edited
Loading

Description:

Port - https://github.com/shrpne/postcss-page-break/

Also:

  • fix bug with duplicate properties (still need to check logic for duplicate values)
  • refactor code

BREAKING CHANGE:

No

Related issue (if exists):

No

@kdy1 kdy1 self-assigned this Dec 21, 2022
@kdy1 kdy1 added this to the Planned milestone Dec 21, 2022
kdy1
kdy1 previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_prefixer

@kdy1 kdy1 enabled auto-merge (squash) December 21, 2022 03:34
swc-bot
swc-bot reviewed Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge December 21, 2022 08:29
@alexander-akait
Copy link
Contributor Author

@kdy1 Rebased and fixed

@kdy1 kdy1 enabled auto-merge (squash) December 21, 2022 13:52
@kdy1 kdy1 merged commit 27a8b7e into swc-project:main Dec 21, 2022
@alexander-akait alexander-akait deleted the feat-page-break branch December 21, 2022 14:06
@kdy1 kdy1 modified the milestones: Planned, v1.3.25 Jan 5, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot