Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css/parser): normalize at-rules #6705

Merged
merged 9 commits into from
Jan 14, 2023
Merged

feat(css/parser): normalize at-rules #6705

merged 9 commits into from
Jan 14, 2023

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Dec 21, 2022 •
edited

Description:

Here:

  • normalize ident to lowercase where it is allowed by spec
  • improve AST for custom media by spec (comment in code)
  • more tests

BREAKING CHANGE:

Yes

Related issue (if exists):

No

@kdy1 kdy1 added this to the Planned milestone Dec 22, 2022
@kdy1 kdy1 self-assigned this Dec 22, 2022
kdy1
kdy1 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 enabled auto-merge (squash) December 22, 2022 01:42
swc-bot
swc-bot reviewed Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

kdy1
kdy1 reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge PRs that breaks AST in future

@kdy1 kdy1 disabled auto-merge December 22, 2022 02:18
kdy1
kdy1 requested changes Dec 22, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@alexander-akait
Copy link
Collaborator Author

@kdy1 Rebased and fixed

kdy1
kdy1 previously approved these changes Dec 27, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) December 27, 2022 12:17
swc-bot
swc-bot reviewed Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge January 3, 2023 03:15
@alexander-akait
Copy link
Collaborator Author

@kdy1 Rebased and fixed

@kdy1 kdy1 enabled auto-merge (squash) January 14, 2023 08:52
@kdy1 kdy1 merged commit 43e7519 into swc-project:main Jan 14, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.27 Jan 17, 2023
@alexander-akait alexander-akait deleted the feat-normalize-at-rules branch January 20, 2023 14:30
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexander-akait @kdy1 @swc-bot