Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/codegen): Skip lo of a program if body is not empty #6773

Merged
merged 11 commits into from Jan 10, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 10, 2023

@kdy1 kdy1 added this to the Planned milestone Jan 10, 2023
@kdy1 kdy1 self-assigned this Jan 10, 2023
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset ci


swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 requested a review from jridgewell January 10, 2023 03:57
@kdy1
Copy link
Member Author

kdy1 commented Jan 10, 2023

@jridgewell Do you think this is correct?
The actual problem of #6767 is that the span.lo of Module does not match span.lo of the first item.

@kdy1 kdy1 marked this pull request as ready for review January 10, 2023 03:58
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 10, 2023
jridgewell
jridgewell previously approved these changes Jan 10, 2023
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solves this particular case, but the larger solution would be to to mark DUMMY_SPAN locations with a source-less mapping. We'd need to remove the dummy checks from https://github.com/swc-project/swc/blob/b102504eb9e0afc5a79989c9cd8a3952ab1e2689/crates/swc_html_codegen/src/writer/basic.rs.

@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via 95881e1 January 10, 2023 04:58
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 10, 2023
@kdy1
Copy link
Member Author

kdy1 commented Jan 10, 2023

I tried it, but it resulted in extremely huge source maps.
So I reverted it.

The problem was that so many nodes have DUMMY_SP

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 10, 2023
@@ -94,7 +94,10 @@ where
#[emitter]
pub fn emit_module(&mut self, node: &Module) -> Result {
self.emit_leading_comments_of_span(node.span(), false)?;
srcmap!(node, true);

if node.body.is_empty() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is still required to fix #6767

@@ -1,5 +1,5 @@
{
"mappings": "AAAA;;;;;;;;;;;IA2BYA,IAAI;IAEHC,MAAM,MAANA;IACAC,QAAQ,MAARA;IAEAC,MAAM,MAANA;IACAC,KAAK,MAALA;IAEAC,MAAM,MAANA;IAEAC,MAAM,MAANA;IAKAC,OAAO,MAAPA;IAGAC,GAAG,MAAHA;;;;;;;kCA7CuC;8BACJ;gCAC1B;oFAwBR;AAGP,MAAMP,SAAqC,IAAM,IAAIQ;AACrD,MAAMP,WAA2C,IACpD,IAAIQ;AACD,MAAMP,SAAuC,IAAM,IAAIQ;AACvD,MAAMP,QAAyC,IAClD,IAAIQ;AACD,MAAMP,SAA2C,IACpD,IAAIQ;AACD,MAAMP,SAGT,CAACQ,QAAkC,EAAE,GACrC,IAAIC,wBAAwBD;AACzB,MAAMP,UAAgD,IACzD,IAAIS;AAED,MAAMR,MAAM;IACfJ,OAAQ,IACJ,IAAIa;IACRX,QAAS,IACL,IAAIY;AACZ;IAGI,uCACA,yCACA,2CACA;AAJJ,MAAMT,oBAAoBU,iCAAe;IAMrCC,OAAO,GAAGA,MAA4B,EAAQ;oCACpCA,SAASA,OAAOC,GAAG,CAACC,yBAAW;QACrC,OAAO,IAAI;IACf;IAEApB,SAASA,QAA6B,EAAQ;oCACpCA,WAAWoB,IAAAA,yBAAW,EAACpB;QAC7B,OAAO,IAAI;IACf;IAEAqB,WAAWA,UAAqC,EAAQ;oCAC9CA,aAAaA,YAAYF,IAAIC,yBAAW;QAC9C,OAAO,IAAI;IACf;IAEAE,eAAeA,cAAyC,EAAQ;oCACtDA,iBAAiBF,IAAAA,yBAAW,EAACE;QACnC,OAAO,IAAI;IACf;IAEAC,QAAc;QACV,OAAO;YACHL,MAAM,wBAAE,IAAI,EAAEA;YACdlB,QAAQ,wBAAE,IAAI,EAAEA;YAChBqB,UAAU,wBAAE,IAAI,EAAEA;YAClBC,cAAc,wBAAE,IAAI,EAAEA;QAC1B;IACJ;;;QAhCA,6BAAA;;mBAAuB,EAAE;;QACzB,6BAAA;;mBAAuBE;;QACvB,6BAAA;;mBAAgCA;;QAChC,6BAAA;;mBAAmCA;;;AA8BvC;IAGI,sCACA;AAFJ,MAAMhB,wBAAwBS,iCAAe;IAIzCL,MAAMA,KAA+B,EAAQ;oCACnCA,QAAQA,MAAMO,GAAG,CAACC,yBAAW;QACnC,OAAO,IAAI;IACf;IAEAK,OAAOA,MAAgC,EAAQ;oCACrCA,SAASA,OAAON,GAAG,CAACC,yBAAW;QACrC,OAAO,IAAI;IACf;IAEAG,QAAkB;QACd,OAAO;YACHX,KAAK,wBAAE,IAAI,EAAEA;YACba,MAAM,wBAAE,IAAI,EAAEA;QAClB;IACJ;;;QAlBA,6BAAA;;mBAA0B,EAAE;;QAC5B,6BAAA;;mBAA2B,EAAE;;;AAkBjC;IAGI;AADJ,MAAMhB,sBAAsBQ,iCAAe;IAGvCS,QAAQA,OAAoC,EAAQ;oCAC1CA,UAAUN,IAAAA,yBAAW,EAACM;QAC5B,OAAO,IAAI;IACf;IAEAH,QAAgB;QACZ,OAAO;YACHG,OAAO,wBAAE,IAAI,EAAEA;QACnB;IACJ;;;QAXA,6BAAA;;mBAA8BC,IAAAA,qBAAK,IAAGJ,KAAK;;;AAY/C;IAGI,uCACA,uCACA,2CACA;AAJJ,MAAMR,4BAA4Ba,oCAAkB;IAMhDhB,MAAMA,KAA2C,EAAQ;oCAC/CA,SAAQA,MAAMO,GAAG,CAACU,0BAAY;QACpC,OAAO,IAAI;IACf;IAEA1B,OAAOA,MAAyC,EAAQ;oCAC9CA,SAAS0B,IAAAA,0BAAY,EAAC1B,UAAU,EAAE;QACxC,OAAO,IAAI;IACf;IAEA2B,WAAWA,UAAsD,EAAQ;oCAC/DA,aAAaA,WAAWX,GAAG,CAACU,0BAAY;QAC9C,OAAO,IAAI;IACf;IAEAE,sBACIA,qBAA2D,EACvD;oCACEA,wBAAwBA,sBAAsBZ,GAAG,CAACU,0BAAY;QACpE,OAAO,IAAI;IACf;IAEAG,cAAcC,cAAuC,EAAa;QAC9D,OAAO;YACHC,IAAIC,IAAAA,kBAAI,EACJ,mCACA,IAAI,EAAEvB,gCACN,IAAI,EAAEkB,oCACN,IAAI,EAAEC,+CACN,IAAI,EAAE5B;YAEVS,OAAOqB,eAAeG,KAAK,uBAAC,IAAI,EAAExB;YAClCT,QAAQ8B,eAAeI,KAAK,uBAAC,IAAI,EAAElC;YACnC2B,YAAYG,eAAeG,KAAK,uBAAC,IAAI,EAAEN;YACvCC,uBAAuBE,eAAeG,KAAK,uBACvC,IAAI,EAAEL;QAEd;IACJ;;;QA3CA,6BAAA;;mBAAsC,EAAE;;QACxC,6BAAA;;mBAAmCP;;QACnC,6BAAA;;mBAAiD,EAAE;;QACnD,6BAAA;;mBAAsD,EAAE;;;AAyC5D;IAGI;AADJ,MAAMd,yBAAyBO,iCAAe;IAG1CL,MAAMA,KAA+B,EAAQ;QACzC,sBAAA,IAAI,EAAE0B,aAAW1B,KAAK,CAAC;YAACA;SAAM;QAC9B,OAAO,IAAI;IACf;IAEAT,OAAOA,MAA6B,EAAQ;QACxC,IAAIA,QAAQ;YACR,sBAAA,IAAI,EAAEmC,aAAWnC,MAAM,CAAC;gBAACA;aAAO;QACpC,CAAC;QACD,OAAO,IAAI;IACf;IAEA2B,WAAWA,UAA0C,EAAQ;QACzD,sBAAA,IAAI,EAAEQ,aAAWR,UAAU,CAAC;YAACA;SAAW;QACxC,OAAO,IAAI;IACf;IAEAC,sBACIA,qBAA+C,EAC3C;QACJ,sBAAA,IAAI,EAAEO,aAAWP,qBAAqB,CAAC;YAACA;SAAsB;QAC9D,OAAO,IAAI;IACf;IAEAR,QAAmB;QACf,OAAO,sBAAA,IAAI,EAAEe,aAAWf,KAAK;IACjC;;;QA5BA,6BAAA;;mBAAmC,IAAIR;;;AA6B3C;IAGI,wCACA;AAFJ,MAAMJ,0BAA0BM,iCAAe;IAI3CsB,QAAQA,OAA8B,EAAQ;oCACpCA,UAAUA;QAChB,OAAO,IAAI;IACf;IAEAtC,OAAOA,MAAwB,EAAQ;oCAC7BA,SAASmB,IAAAA,yBAAW,EAACnB;QAC3B,OAAO,IAAI;IACf;IAEAsB,QAAoB;QAChB,OAAO;YACHgB,OAAO,wBAAE,IAAI,EAAEA;YACftC,MAAM,wBAAE,IAAI,EAAEA;QAClB;IACJ;;;QAlBA,6BAAA;;mBAAkC;;QAClC,6BAAA;;mBAAmBuB;;;AAkBvB;IAGI;AADJ,MAAMR,gCAAgCY,oCAAkB;IAGpDhB,MAAMA,KAA2C,EAAQ;oCAC/CA,SAAQA,MAAMO,GAAG,CAACU,0BAAY;QACpC,OAAO,IAAI;IACf;IAEAG,cAAcC,cAAuC,EAAiB;QAClE,MAAMC,KAAKC,IAAAA,kBAAI,EAAC,wCAAkB,IAAI,EAAEvB;QACxC,OAAO;YACHsB;YACAtB,OAAOqB,eAAeG,KAAK,uBAAC,IAAI,EAAExB;QACtC;IACJ;;;QAbA,6BAAA;;mBAAsC,EAAE;;;AAc5C;IAGI;AADJ,MAAMC,6BAA6BI,iCAAe;IAQ9CL,MAAM,GAAGA,KAA+B,EAAQ;QAC5C,sBAAA,IAAI,EAAE0B,cAAW1B,KAAK,CAAC;YAACA;SAAM;QAC9B,OAAO,IAAI;IACf;IAEAW,QAAuB;QACnB,OAAO,sBAAA,IAAI,EAAEe,cAAWf,KAAK;IACjC;IAZAiB,YAAY,GAAG5B,KAA+B,CAAE;QAC5C,KAAK;QAHT,6BAAA;;mBAAuC,IAAII;;QAIvC,IAAI,CAACJ,KAAK,IAAIA;IAClB;AAUJ;IAGI,uCACA;AAFJ,MAAME,8BAA8BG,iCAAe;IAI/CL,MAAM,GAAGA,KAA+B,EAAQ;oCACtCA,SAAQA,MAAMO,GAAG,CAACC,yBAAW;QACnC,OAAO,IAAI;IACf;IAEAK,OAAO,GAAGA,MAAgC,EAAQ;oCACxCA,UAASA,OAAON,GAAG,CAACC,yBAAW;QACrC,OAAO,IAAI;IACf;IAEAG,QAAwB;QACpB,OAAO;YACHX,KAAK,wBAAE,IAAI,EAAEA;YACba,MAAM,wBAAE,IAAI,EAAEA;QAClB;IACJ;;;QAlBA,6BAAA;;mBAA0B,EAAE;;QAC5B,6BAAA;;mBAA2B,EAAE;;;AAkBjC",
"mappings": "AAAA,YAAA;AAAA,MAAA,CAAA,cAAA,CAAA,OAAA,EAAA,YAAA;IAAA,KAAA,EAAA,IAAA;;SAAA,OAAA,CAAA,MAAA,EAAA,GAAA;YAAA,IAAA,IAAA,GAAA,CAAA,MAAA,CAAA,cAAA,CAAA,MAAA,EAAA,IAAA;QAAA,UAAA,EAAA,IAAA;QAAA,GAAA,EAAA,GAAA,CAAA,IAAA;;;AAAA,OAAA,CAAA,OAAA;IA2BYA,AA3BZ,IAAA,AA2BgB,MA3BhB,iBAAA;IA6BaC,AA7Bb,MAAA,AA6BmB,MAANA,AA7Bb,MAAA;IA8BaC,AA9Bb,QAAA,AA8BqB,MAARA,AA9Bb,QAAA;IAgCaC,AAhCb,MAAA,AAgCmB,MAANA,AAhCb,MAAA;IAiCaC,AAjCb,KAAA,AAiCkB,MAALA,AAjCb,KAAA;IAmCaC,AAnCb,MAAA,AAmCmB,MAANA,AAnCb,MAAA;IAqCaC,AArCb,MAAA,AAqCmB,MAANA,AArCb,MAAA;IA0CaC,AA1Cb,OAAA,AA0CoB,MAAPA,AA1Cb,OAAA;IA6CaC,AA7Cb,GAAA,AA6CgB,MAAHA,AA7Cb,GAAA;;MAAA,qBAAA,GAAA,OAAA,CAAA,8CAAA,EAAA,OAAA;MAAA,sBAAA,GAAA,OAAA,CAAA,+CAAA,EAAA,OAAA;MAAA,qBAAA,GAAA,OAAA,CAAA,8CAAA,EAAA,OAAA;MAAA,WAAA,GAAA,OAAA,CAAA,kCAAA,EAAA,OAAA;MAAA,uBAAA,GAAA,OAAA,CAAA,+CAAA,EAAA,OAAA;MAAA,iBAAA,GAAA,OAAA,CAAoD,AAApD,oBAAA;MAAA,aAAA,GAAA,OAAA,CACgD,AADhD,iBAAA;MAAA,eAAA,GAAA,OAAA,CAEsB,AAFtB,kBAAA;MAAA,iBAAA,iBAAA,uBAAA,CAAA,WAAA,CAAA,OAAA,CA0Bc,AA1Bd,oBAAA,GAAA,OAAA;AA6BO,MAAMP,AA7Bb,MAAA,GA6BkD,IAAM,IAAIQ,AA7B5D,WAAA;AA8BO,MAAMP,AA9Bb,QAAA,GA8BwD,IACpD,IAAIQ,AA/BR,eAAA;AAgCO,MAAMP,AAhCb,MAAA,GAgCoD,IAAM,IAAIQ,AAhC9D,aAAA;AAiCO,MAAMP,AAjCb,KAAA,GAiCsD,IAClD,IAAIQ,AAlCR,gBAAA;AAmCO,MAAMP,AAnCb,MAAA,GAmCwD,IACpD,IAAIQ,AApCR,iBAAA;AAqCO,MAAMP,AArCb,MAAA,GAwCI,CAACQ,AAxCL,KAAA,GAwCuC,EAAE,GACrC,IAAIC,AAzCR,oBAAA,IAyCgCD,AAzChC,KAAA;AA0CO,MAAMP,AA1Cb,OAAA,GA0C6D,IACzD,IAAIS,AA3CR,qBAAA;AA6CO,MAAMR,AA7Cb,GAAA,GA6CmB;IACfJ,AA9CJ,KAAA,EA8CY,IACJ,IAAIa,AA/CZ,mBAAA;IAgDIX,AAhDJ,MAAA,EAgDa,IACL,IAAIY,AAjDZ,uBAAA;AAkDA;IAGI,AArDJ,OAAA,qBAAA,OAAA,IAsDI,AAtDJ,SAAA,qBAAA,OAAA,IAuDI,AAvDJ,WAAA,qBAAA,OAAA,IAwDI,AAxDJ,eAAA,qBAAA,OAAA;AAoDA,MAAMT,AApDN,WAAA,SAoD0BU,AApD1B,iBAAA,CAAA,eAAA,AAoDyC;IAMrCC,AA1DJ,MAAA,CA0DW,GAAGA,AA1Dd,MAAA,AA0D0C,EAAQ;QA1DlD,qBAAA,CAAA,IAAA,EA2DcA,AA3Dd,OAAA,EA2DuBA,AA3DvB,MAAA,CA2D8BC,AA3D9B,GAAA,AA2DiC,CAACC,AA3DlC,aAAA,CAAA,WAAA,AA2D6C;QACrC,OAAO,IAAI;IACf;IAEApB,AA/DJ,QAAA,CA+DaA,AA/Db,QAAA,AA+D0C,EAAQ;QA/DlD,qBAAA,CAAA,IAAA,EAgEcA,AAhEd,SAAA,EAgEyBoB,CAhEzB,CAAA,EAgEyBA,AAhEzB,aAAA,CAAA,WAAA,AAgEoC,EAACpB,AAhErC,QAAA;QAiEQ,OAAO,IAAI;IACf;IAEAqB,AApEJ,UAAA,CAoEeA,AApEf,UAAA,AAoEoD,EAAQ;QApE5D,qBAAA,CAAA,IAAA,EAqEcA,AArEd,WAAA,EAqE2BA,AArE3B,UAAA,EAqEuCF,AArEvC,GAAA,CAqE2CC,AArE3C,aAAA,CAAA,WAAA,AAqEsD;QAC9C,OAAO,IAAI;IACf;IAEAE,AAzEJ,cAAA,CAyEmBA,AAzEnB,cAAA,AAyE4D,EAAQ;QAzEpE,qBAAA,CAAA,IAAA,EA0EcA,AA1Ed,eAAA,EA0E+BF,CA1E/B,CAAA,EA0E+BA,AA1E/B,aAAA,CAAA,WAAA,AA0E0C,EAACE,AA1E3C,cAAA;QA2EQ,OAAO,IAAI;IACf;IAEAC,AA9EJ,KAAA,GA8EkB;QACV,OAAO;YACHL,AAhFZ,MAAA,AAgFkB,EAhFlB,qBAAA,CAgFoB,IAAI,EAAEA,AAhF1B,OAAA;YAiFYlB,AAjFZ,QAAA,AAiFoB,EAjFpB,qBAAA,CAiFsB,IAAI,EAAEA,AAjF5B,SAAA;YAkFYqB,AAlFZ,UAAA,AAkFsB,EAlFtB,qBAAA,CAkFwB,IAAI,EAAEA,AAlF9B,WAAA;YAmFYC,AAnFZ,cAAA,AAmF0B,EAnF1B,qBAAA,CAmF4B,IAAI,EAAEA,AAnFlC,eAAA;QAoFQ;IACJ;gBArFJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QAqDI,AArDJ,sBAAA,CAAA,IAAA,EAqDI,AArDJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAqD2B,EAAE;;QACzB,AAtDJ,sBAAA,CAAA,IAAA,EAsDI,AAtDJ,SAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAsD2BE,AAtD3B,SAAA;;QAuDI,AAvDJ,sBAAA,CAAA,IAAA,EAuDI,AAvDJ,WAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAuDoCA,AAvDpC,SAAA;;QAwDI,AAxDJ,sBAAA,CAAA,IAAA,EAwDI,AAxDJ,eAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAwDuCA,AAxDvC,SAAA;;;AAsFA;IAGI,AAzFJ,MAAA,qBAAA,OAAA,IA0FI,AA1FJ,OAAA,qBAAA,OAAA;AAwFA,MAAMhB,AAxFN,eAAA,SAwF8BS,AAxF9B,iBAAA,CAAA,eAAA,AAwF6C;IAIzCL,AA5FJ,KAAA,CA4FUA,AA5FV,KAAA,AA4FyC,EAAQ;QA5FjD,qBAAA,CAAA,IAAA,EA6FcA,AA7Fd,MAAA,EA6FsBA,AA7FtB,KAAA,CA6F4BO,AA7F5B,GAAA,AA6F+B,CAACC,AA7FhC,aAAA,CAAA,WAAA,AA6F2C;QACnC,OAAO,IAAI;IACf;IAEAK,AAjGJ,MAAA,CAiGWA,AAjGX,MAAA,AAiG2C,EAAQ;QAjGnD,qBAAA,CAAA,IAAA,EAkGcA,AAlGd,OAAA,EAkGuBA,AAlGvB,MAAA,CAkG8BN,AAlG9B,GAAA,AAkGiC,CAACC,AAlGlC,aAAA,CAAA,WAAA,AAkG6C;QACrC,OAAO,IAAI;IACf;IAEAG,AAtGJ,KAAA,GAsGsB;QACd,OAAO;YACHX,AAxGZ,KAAA,AAwGiB,EAxGjB,qBAAA,CAwGmB,IAAI,EAAEA,AAxGzB,MAAA;YAyGYa,AAzGZ,MAAA,AAyGkB,EAzGlB,qBAAA,CAyGoB,IAAI,EAAEA,AAzG1B,OAAA;QA0GQ;IACJ;gBA3GJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QAyFI,AAzFJ,sBAAA,CAAA,IAAA,EAyFI,AAzFJ,MAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAyF8B,EAAE;;QAC5B,AA1FJ,sBAAA,CAAA,IAAA,EA0FI,AA1FJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA0F+B,EAAE;;;AAkBjC;IAGI,AA/GJ,QAAA,qBAAA,OAAA;AA8GA,MAAMhB,AA9GN,aAAA,SA8G4BQ,AA9G5B,iBAAA,CAAA,eAAA,AA8G2C;IAGvCS,AAjHJ,OAAA,CAiHYA,AAjHZ,OAAA,AAiHgD,EAAQ;QAjHxD,qBAAA,CAAA,IAAA,EAkHcA,AAlHd,QAAA,EAkHwBN,CAlHxB,CAAA,EAkHwBA,AAlHxB,aAAA,CAAA,WAAA,AAkHmC,EAACM,AAlHpC,OAAA;QAmHQ,OAAO,IAAI;IACf;IAEAH,AAtHJ,KAAA,GAsHoB;QACZ,OAAO;YACHG,AAxHZ,OAAA,AAwHmB,EAxHnB,qBAAA,CAwHqB,IAAI,EAAEA,AAxH3B,QAAA;QAyHQ;IACJ;gBA1HJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QA+GI,AA/GJ,sBAAA,CAAA,IAAA,EA+GI,AA/GJ,QAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA+GkCC,CA/GlC,CAAA,EA+GkCA,AA/GlC,eAAA,CAAA,KAAA,AA+GuC,IAAGJ,AA/G1C,KAAA,AA+G+C;;;AAY/C;IAGI,AA9HJ,OAAA,qBAAA,OAAA,IA+HI,AA/HJ,OAAA,qBAAA,OAAA,IAgII,AAhIJ,WAAA,qBAAA,OAAA,IAiII,AAjIJ,sBAAA,qBAAA,OAAA;AA6HA,MAAMR,AA7HN,mBAAA,SA6HkCa,AA7HlC,iBAAA,CAAA,kBAAA,AA6HoD;IAMhDhB,AAnIJ,KAAA,CAmIUA,AAnIV,KAAA,AAmIqD,EAAQ;QAnI7D,qBAAA,CAAA,IAAA,EAoIcA,AApId,OAAA,EAoIsBA,AApItB,KAAA,CAoI4BO,AApI5B,GAAA,AAoI+B,CAACU,AApIhC,aAAA,CAAA,YAAA,AAoI4C;QACpC,OAAO,IAAI;IACf;IAEA1B,AAxIJ,MAAA,CAwIWA,AAxIX,MAAA,AAwIoD,EAAQ;QAxI5D,qBAAA,CAAA,IAAA,EAyIcA,AAzId,OAAA,EAyIuB0B,CAzIvB,CAAA,EAyIuBA,AAzIvB,aAAA,CAAA,YAAA,AAyImC,EAAC1B,AAzIpC,MAAA,IAyI8C,EAAE;QACxC,OAAO,IAAI;IACf;IAEA2B,AA7IJ,UAAA,CA6IeA,AA7If,UAAA,AA6IqE,EAAQ;QA7I7E,qBAAA,CAAA,IAAA,EA8IcA,AA9Id,WAAA,EA8I2BA,AA9I3B,UAAA,CA8IsCX,AA9ItC,GAAA,AA8IyC,CAACU,AA9I1C,aAAA,CAAA,YAAA,AA8IsD;QAC9C,OAAO,IAAI;IACf;IAEAE,AAlJJ,qBAAA,CAmJQA,AAnJR,qBAAA,AAmJmE,EACvD;QApJZ,qBAAA,CAAA,IAAA,EAqJcA,AArJd,sBAAA,EAqJsCA,AArJtC,qBAAA,CAqJ4DZ,AArJ5D,GAAA,AAqJ+D,CAACU,AArJhE,aAAA,CAAA,YAAA,AAqJ4E;QACpE,OAAO,IAAI;IACf;IAEAG,AAzJJ,aAAA,CAyJkBC,AAzJlB,cAAA,AAyJyD,EAAa;QAC9D,OAAO;YACHC,AA3JZ,EAAA,EA2JgBC,CA3JhB,CAAA,EA2JgBA,AA3JhB,aAAA,CAAA,IAAA,AA2JoB,EACJ,AA5JhB,WAAA,EAAA,qBAAA,CA6JgB,IAAI,EAAEvB,AA7JtB,OAAA,GAAA,qBAAA,CA8JgB,IAAI,EAAEkB,AA9JtB,WAAA,GAAA,qBAAA,CA+JgB,IAAI,EAAEC,AA/JtB,sBAAA,GAAA,qBAAA,CAgKgB,IAAI,EAAE5B,AAhKtB,OAAA;YAkKYS,AAlKZ,KAAA,EAkKmBqB,AAlKnB,cAAA,CAkKkCG,AAlKlC,KAAA,AAkKuC,CAlKvC,qBAAA,CAkKwC,IAAI,EAAExB,AAlK9C,OAAA;YAmKYT,AAnKZ,MAAA,EAmKoB8B,AAnKpB,cAAA,CAmKmCI,AAnKnC,KAAA,AAmKwC,CAnKxC,qBAAA,CAmKyC,IAAI,EAAElC,AAnK/C,OAAA;YAoKY2B,AApKZ,UAAA,EAoKwBG,AApKxB,cAAA,CAoKuCG,AApKvC,KAAA,AAoK4C,CApK5C,qBAAA,CAoK6C,IAAI,EAAEN,AApKnD,WAAA;YAqKYC,AArKZ,qBAAA,EAqKmCE,AArKnC,cAAA,CAqKkDG,AArKlD,KAAA,AAqKuD,CArKvD,qBAAA,CAsKgB,IAAI,EAAEL,AAtKtB,sBAAA;QAwKQ;IACJ;gBAzKJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QA8HI,AA9HJ,sBAAA,CAAA,IAAA,EA8HI,AA9HJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA8H0C,EAAE;;QACxC,AA/HJ,sBAAA,CAAA,IAAA,EA+HI,AA/HJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA+HuCP,AA/HvC,SAAA;;QAgII,AAhIJ,sBAAA,CAAA,IAAA,EAgII,AAhIJ,WAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAgIqD,EAAE;;QACnD,AAjIJ,sBAAA,CAAA,IAAA,EAiII,AAjIJ,sBAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAiI0D,EAAE;;;AAyC5D;IAGI,AA7KJ,WAAA,qBAAA,OAAA;AA4KA,MAAMd,AA5KN,gBAAA,SA4K+BO,AA5K/B,iBAAA,CAAA,eAAA,AA4K8C;IAG1CL,AA/KJ,KAAA,CA+KUA,AA/KV,KAAA,AA+KyC,EAAQ;QACzC,AAhLR,qBAAA,CAgLQ,IAAI,EAAE0B,AAhLd,WAAA,EAgLyB1B,AAhLzB,KAAA,AAgL8B,CAAC;YAACA,AAhLhC,KAAA;SAgLsC;QAC9B,OAAO,IAAI;IACf;IAEAT,AApLJ,MAAA,CAoLWA,AApLX,MAAA,AAoLwC,EAAQ;QACxC,IAAIA,AArLZ,MAAA,EAqLoB;YACR,AAtLZ,qBAAA,CAsLY,IAAI,EAAEmC,AAtLlB,WAAA,EAsL6BnC,AAtL7B,MAAA,AAsLmC,CAAC;gBAACA,AAtLrC,MAAA;aAsL4C;QACpC,CAAC;QACD,OAAO,IAAI;IACf;IAEA2B,AA3LJ,UAAA,CA2LeA,AA3Lf,UAAA,AA2LyD,EAAQ;QACzD,AA5LR,qBAAA,CA4LQ,IAAI,EAAEQ,AA5Ld,WAAA,EA4LyBR,AA5LzB,UAAA,AA4LmC,CAAC;YAACA,AA5LrC,UAAA;SA4LgD;QACxC,OAAO,IAAI;IACf;IAEAC,AAhMJ,qBAAA,CAiMQA,AAjMR,qBAAA,AAiMuD,EAC3C;QACJ,AAnMR,qBAAA,CAmMQ,IAAI,EAAEO,AAnMd,WAAA,EAmMyBP,AAnMzB,qBAAA,AAmM8C,CAAC;YAACA,AAnMhD,qBAAA;SAmMsE;QAC9D,OAAO,IAAI;IACf;IAEAR,AAvMJ,KAAA,GAuMuB;QACf,OAAO,AAxMf,qBAAA,CAwMe,IAAI,EAAEe,AAxMrB,WAAA,EAwMgCf,AAxMhC,KAAA,AAwMqC;IACjC;gBAzMJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QA6KI,AA7KJ,sBAAA,CAAA,IAAA,EA6KI,AA7KJ,WAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA6KuC,IAAIR,AA7K3C,mBAAA;;;AA0MA;IAGI,AA7MJ,QAAA,qBAAA,OAAA,IA8MI,AA9MJ,OAAA,qBAAA,OAAA;AA4MA,MAAMJ,AA5MN,iBAAA,SA4MgCM,AA5MhC,iBAAA,CAAA,eAAA,AA4M+C;IAI3CsB,AAhNJ,OAAA,CAgNYA,AAhNZ,OAAA,AAgN0C,EAAQ;QAhNlD,qBAAA,CAAA,IAAA,EAiNcA,AAjNd,QAAA,EAiNwBA,AAjNxB,OAAA;QAkNQ,OAAO,IAAI;IACf;IAEAtC,AArNJ,MAAA,CAqNWA,AArNX,MAAA,AAqNmC,EAAQ;QArN3C,qBAAA,CAAA,IAAA,EAsNcA,AAtNd,OAAA,EAsNuBmB,CAtNvB,CAAA,EAsNuBA,AAtNvB,aAAA,CAAA,WAAA,AAsNkC,EAACnB,AAtNnC,MAAA;QAuNQ,OAAO,IAAI;IACf;IAEAsB,AA1NJ,KAAA,GA0NwB;QAChB,OAAO;YACHgB,AA5NZ,OAAA,AA4NmB,EA5NnB,qBAAA,CA4NqB,IAAI,EAAEA,AA5N3B,QAAA;YA6NYtC,AA7NZ,MAAA,AA6NkB,EA7NlB,qBAAA,CA6NoB,IAAI,EAAEA,AA7N1B,OAAA;QA8NQ;IACJ;gBA/NJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QA6MI,AA7MJ,sBAAA,CAAA,IAAA,EA6MI,AA7MJ,QAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA6MsC,AA7MtC,MAAA;;QA8MI,AA9MJ,sBAAA,CAAA,IAAA,EA8MI,AA9MJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EA8MuBuB,AA9MvB,SAAA;;;AAgOA;IAGI,AAnOJ,OAAA,qBAAA,OAAA;AAkOA,MAAMR,AAlON,uBAAA,SAkOsCY,AAlOtC,iBAAA,CAAA,kBAAA,AAkOwD;IAGpDhB,AArOJ,KAAA,CAqOUA,AArOV,KAAA,AAqOqD,EAAQ;QArO7D,qBAAA,CAAA,IAAA,EAsOcA,AAtOd,OAAA,EAsOsBA,AAtOtB,KAAA,CAsO4BO,AAtO5B,GAAA,AAsO+B,CAACU,AAtOhC,aAAA,CAAA,YAAA,AAsO4C;QACpC,OAAO,IAAI;IACf;IAEAG,AA1OJ,aAAA,CA0OkBC,AA1OlB,cAAA,AA0OyD,EAAiB;QAClE,MAAMC,AA3Od,EAAA,GA2OmBC,CA3OnB,CAAA,EA2OmBA,AA3OnB,aAAA,CAAA,IAAA,AA2OuB,EAAC,AA3OxB,gBAAA,EAAA,qBAAA,CA2O0C,IAAI,EAAEvB,AA3OhD,OAAA;QA4OQ,OAAO;YACHsB,AA7OZ,EAAA;YA8OYtB,AA9OZ,KAAA,EA8OmBqB,AA9OnB,cAAA,CA8OkCG,AA9OlC,KAAA,AA8OuC,CA9OvC,qBAAA,CA8OwC,IAAI,EAAExB,AA9O9C,OAAA;QA+OQ;IACJ;gBAhPJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QAmOI,AAnOJ,sBAAA,CAAA,IAAA,EAmOI,AAnOJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAmO0C,EAAE;;;AAc5C;IAGI,AApPJ,YAAA,qBAAA,OAAA;AAmPA,MAAMC,AAnPN,oBAAA,SAmPmCI,AAnPnC,iBAAA,CAAA,eAAA,AAmPkD;IAQ9CL,AA3PJ,KAAA,CA2PU,GAAGA,AA3Pb,KAAA,AA2P4C,EAAQ;QAC5C,AA5PR,qBAAA,CA4PQ,IAAI,EAAE0B,AA5Pd,YAAA,EA4PyB1B,AA5PzB,KAAA,AA4P8B,CAAC;YAACA,AA5PhC,KAAA;SA4PsC;QAC9B,OAAO,IAAI;IACf;IAEAW,AAhQJ,KAAA,GAgQ2B;QACnB,OAAO,AAjQf,qBAAA,CAiQe,IAAI,EAAEe,AAjQrB,YAAA,EAiQgCf,AAjQhC,KAAA,AAiQqC;IACjC;IAZAiB,YAAY,GAAG5B,AAtPnB,KAAA,AAsPkD,CAAE;QAC5C,KAAK;QAHT,AApPJ,sBAAA,CAAA,IAAA,EAoPI,AApPJ,YAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAoP2C,IAAII,AApP/C,uBAAA;;QAwPQ,IAAI,CAACJ,AAxPb,KAAA,AAwPkB,IAAIA,AAxPtB,KAAA;IAyPI;AAUJ;IAGI,AAtQJ,OAAA,qBAAA,OAAA,IAuQI,AAvQJ,QAAA,qBAAA,OAAA;AAqQA,MAAME,AArQN,qBAAA,SAqQoCG,AArQpC,iBAAA,CAAA,eAAA,AAqQmD;IAI/CL,AAzQJ,KAAA,CAyQU,GAAGA,AAzQb,KAAA,AAyQ4C,EAAQ;QAzQpD,qBAAA,CAAA,IAAA,EA0QcA,AA1Qd,OAAA,EA0QsBA,AA1QtB,KAAA,CA0Q4BO,AA1Q5B,GAAA,AA0Q+B,CAACC,AA1QhC,aAAA,CAAA,WAAA,AA0Q2C;QACnC,OAAO,IAAI;IACf;IAEAK,AA9QJ,MAAA,CA8QW,GAAGA,AA9Qd,MAAA,AA8Q8C,EAAQ;QA9QtD,qBAAA,CAAA,IAAA,EA+QcA,AA/Qd,QAAA,EA+QuBA,AA/QvB,MAAA,CA+Q8BN,AA/Q9B,GAAA,AA+QiC,CAACC,AA/QlC,aAAA,CAAA,WAAA,AA+Q6C;QACrC,OAAO,IAAI;IACf;IAEAG,AAnRJ,KAAA,GAmR4B;QACpB,OAAO;YACHX,AArRZ,KAAA,AAqRiB,EArRjB,qBAAA,CAqRmB,IAAI,EAAEA,AArRzB,OAAA;YAsRYa,AAtRZ,MAAA,AAsRkB,EAtRlB,qBAAA,CAsRoB,IAAI,EAAEA,AAtR1B,QAAA;QAuRQ;IACJ;gBAxRJ,GAAA,IAAA;QAAA,KAAA,IAAA,IAAA;QAsQI,AAtQJ,sBAAA,CAAA,IAAA,EAsQI,AAtQJ,OAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAsQ8B,EAAE;;QAC5B,AAvQJ,sBAAA,CAAA,IAAA,EAuQI,AAvQJ,QAAA;YAAA,QAAA,EAAA,IAAA;YAAA,KAAA,EAuQ+B,EAAE;;;AAkBjC",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jridgewell Is this better than the previous one?

@kdy1
Copy link
Member Author

kdy1 commented Jan 10, 2023

I'll use a separate PR.

@kdy1 kdy1 enabled auto-merge (squash) January 10, 2023 05:21
@kdy1 kdy1 merged commit 3f0f664 into swc-project:main Jan 10, 2023
@kdy1 kdy1 deleted the issue-6767 branch January 10, 2023 06:01
@kdy1 kdy1 modified the milestones: Planned, v1.3.26 Jan 11, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inserting node with DUMMY_SP reuses (next) existing source mapping
2 participants