Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Make AST compressor respect toplevel #6775

Merged
merged 15 commits into from Jan 11, 2023
Merged

fix(es/minifier): Make AST compressor respect toplevel #6775

merged 15 commits into from Jan 11, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 10, 2023

@kdy1 kdy1 added this to the Planned milestone Jan 10, 2023
@kdy1 kdy1 self-assigned this Jan 10, 2023
@kdy1 kdy1 marked this pull request as ready for review January 11, 2023 05:34
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 11, 2023
View reviewed changes
@kdy1 kdy1 requested a review from jridgewell January 11, 2023 05:34
kdy1
kdy1 commented Jan 11, 2023
View reviewed changes
crates/swc_ecma_minifier/tests/fixture/issues/4386/1/input.js
@@ -0,0 +1,57 @@
var application;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reduce this file

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 11, 2023
View reviewed changes
jridgewell
jridgewell previously approved these changes Jan 11, 2023
View reviewed changes
crates/swc_ecma_minifier/src/compress/optimize/inline.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via 2793655 January 11, 2023 05:55
kdy1
kdy1 commented Jan 11, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) January 11, 2023 05:56
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 11, 2023
View reviewed changes
swc-bot
swc-bot reviewed Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 06770cf into swc-project:main Jan 11, 2023
@kdy1 kdy1 deleted the minifier-top-unused branch January 11, 2023 07:04
@kdy1 kdy1 modified the milestones: Planned, v1.3.26 Jan 11, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.26
Development

Successfully merging this pull request may close these issues.

minifier: toplevel = false should prevent operations related to unused
3 participants
@kdy1 @jridgewell @swc-bot