feat: use require for polyfills and helpers #6778
Merged
+239
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Jan 11, 2023
kdy1
requested changes
Jan 11, 2023
RiESAEX
commented
Jan 13, 2023
| @@ -1,2 +1,2 @@ | |||
| var foo = function o() {}; | |||
| var foo = function foo() {}; | |||
There was a problem hiding this comment.
I'm not sure about this change..
I think this is caused by the type change of isModule.
|
Wasm build failed, but I don't know how to fix it. It works fine on my computer. |
kdy1
requested changes
Jan 15, 2023
| @@ -92,6 +91,52 @@ macro_rules! add_import_to { | |||
| }}; | |||
| } | |||
|
|
|||
| macro_rules! add_require_to { | |||
There was a problem hiding this comment.
Please change this to a function.
It will fix Wasm issue
Co-authored-by: Donny/강동윤 <kdy1997.dev@gmail.com>
kdy1
approved these changes
Jan 16, 2023
swc-bot
reviewed
Jan 16, 2023
swc-bot
reviewed
Jan 16, 2023
kdy1
approved these changes
Jan 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
use require for polyfills and helpers
typeof isModule changed to Option.to allow test case set there isModule with swcrc.
#6760
BREAKING CHANGE:
Related issue (if exists):
close #6727