Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/plugin): Fix starter template main field (#6814) #6815

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

alex-dixon
Copy link
Contributor

@alex-dixon alex-dixon commented Jan 14, 2023

Description:
Replace - with _ in generated package.json main field to match what cargo names the output .wasm file. Allows swc-core to load the plugin at runtime.

Related issue:

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Alex Dixon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kdy1 kdy1 added this to the Planned milestone Jan 15, 2023
@kdy1 kdy1 self-assigned this Jan 15, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • dbg-swc

@kdy1 kdy1 enabled auto-merge (squash) January 15, 2023 00:17
@kdy1 kdy1 merged commit 38fb70c into swc-project:main Jan 15, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.27 Jan 17, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Plugin CLI template generates wrong package.json main
3 participants