Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/cli): Implement --config #6835

Merged
merged 3 commits into from Feb 5, 2023
Merged

Conversation

titanous
Copy link
Contributor

Description:

Implements --config. Plugin paths that are explicitly relative (start with ./ or ../) are converted to an absolute path using the current working directory as the base.

Related issue (if exists): aspect-build/rules_swc#149

@kdy1 kdy1 self-assigned this Jan 19, 2023
@kdy1 kdy1 added this to the Planned milestone Jan 19, 2023
@kdy1 kdy1 requested a review from kwonoj January 19, 2023 09:56
@titanous
Copy link
Contributor Author

titanous commented Feb 5, 2023

Hi, any thoughts on this? It's blocking implementing plugins in rules_swc.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc

@kdy1 kdy1 enabled auto-merge (squash) February 5, 2023 21:04
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d993c4d into swc-project:main Feb 5, 2023
@titanous titanous deleted the cli-config branch February 5, 2023 21:36
@kdy1 kdy1 modified the milestones: Planned, v1.3.33, v1.3.34 Feb 8, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants