Skip to content

fix: SystemJS this expressions #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2023
Merged

fix: SystemJS this expressions #6857

merged 4 commits into from
Jan 27, 2023
+100 −16

Conversation

vasilev-alex
Copy link
Contributor

Description:

Fixes this expressions when allow_top_level_this is set to false

BREAKING CHANGE:

No

Related issue (if exists):

#6784

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kdy1 kdy1 added this to the Planned milestone Jan 27, 2023
@kdy1 kdy1 self-assigned this Jan 27, 2023
kdy1
kdy1 requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Requesting a change as CI failed.

swc-bump:

  • swc_ecma_transforms_module

kdy1
kdy1 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) January 27, 2023 09:59
swc-bot
swc-bot reviewed Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 39c75fd into swc-project:main Jan 27, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.30 Jan 28, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot

@kdy1 kdy1

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vasilev-alex @CLAassistant @kdy1 @swc-bot