Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Fix optional chaining pass #6875

Merged
merged 6 commits into from
Jan 30, 2023
Merged

fix(es/compat): Fix optional chaining pass #6875

merged 6 commits into from
Jan 30, 2023
+57 −46

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 30, 2023

kdy1 added 5 commits January 30, 2023 17:24
@kdy1
Enable
09343c8
@kdy1
Enable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c2edfec
@kdy1
state
e2f0024
@kdy1
Fix
8de2d97
@kdy1
Update test refs
327e54c
@kdy1 kdy1 added this to the Planned milestone Jan 30, 2023
@kdy1 kdy1 marked this pull request as ready for review January 30, 2023 09:35
@kdy1 kdy1 enabled auto-merge (squash) January 30, 2023 09:36
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 30, 2023
View reviewed changes
kdy1
kdy1 commented Jan 30, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 self-assigned this Jan 30, 2023
@kdy1 kdy1 merged commit d808864 into swc-project:main Jan 30, 2023
@kdy1 kdy1 deleted the issue-6762 branch January 30, 2023 11:14
@kdy1 kdy1 modified the milestones: Planned, v1.3.31 Jan 30, 2023
kdy1 added a commit to kdy1/swc that referenced this pull request Jan 31, 2023
@kdy1
Revert "fix(es/compat): Fix optional chaining pass (swc-project#6875)"
22bee5b 
This reverts commit d808864.
kdy1 added a commit to kdy1/swc that referenced this pull request Jan 31, 2023
@kdy1
Revert "fix(es/compat): Fix optional chaining pass (swc-project#6875)"
d97c1a0 
This reverts commit d808864.
@lyonbot lyonbot mentioned this pull request Jan 31, 2023
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot]

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.31
Development

Successfully merging this pull request may close these issues.

property access within optional chaining causes property access error at runtime
1 participant
@kdy1