fix(es/minifier): Respect span hygiene from expr simplifier

[kdy1]

Description:

Related issue:

• Closes Optimisation breaks boolean statement #6896.

[kdy1]

Investigation

Playground

This looks like an issue of span hygiene.

After the first pass, the input becomes

console.log("The result should be 0. And it is:", (function(n, e) {
    var r = Math.abs(n - e);
    function t(e) {
        return e < n;
    }
    function u(n) {
        return n > e;
    }
    function c(n1) {
        ;
        ;
        return n1 < n || n1 > e;
    }
    return {
        length: r,
        max: e,
        min: n,
        constrain: function(r) {
            ;
            return c(r) ? r < n ? n : e : r;
        },
        reachedAny: c,
        reachedMax: u,
        reachedMin: t,
        removeOffset: function(n) {
            return r ? n - r * Math.ceil((n - e) / r) : n;
        }
    };
})(0, 3).constrain(-1));

but if I pass this to the minifier it passes.

---

Investigation 2

I verifed the behavior using NOINLINE.

Playground

console.log("The result should be 0. And it is:", function(n, e) {
    var r = Math.abs(n - e);

    function t(e) {
        return e < n
    }

    function u(n) {
        return n > e
    }

    function c(n) {
        return t(n) || u(n)
    }
    return {
        length: r,
        max: e,
        min: n,
        constrain: function(r) {
            return /*#__NOINLINE__*/c(r) ? (/*#__NOINLINE__*/t(r) ? n : e) : r
        },
        reachedAny: c,
        reachedMax: u,
        reachedMin: t,
        removeOffset: function(n) {
            return r ? n - r * Math.ceil((n - e) / r) : n
        }
    }
}(0, 3).constrain(-1));

Investigation 3

Playground

inlining of t(r) was the cause

Investigation 4

https://play.swc.rs/?version=1.3.32&code=H4sIAAAAAAAAA22QTQqDQAyF9z3Fw9UMqFi60%2F7QA3TXC%2Bg4rYJkYCbTTfXuVWtVitkE8r73QqIMOdPouDFPEdwrDaudbxiuMr4pUWgkMa5UombULg1CPDwprg0JCqEl3jv09cotLE645VzFeeEEIerVbDeqPwtYzI6hrGZvCRpH0Djs%2FngvaIMnnKE3ebXJ8zBt2zFtsq3UBVf9L9jmNaXLkXadt3KpQblA8LcT0uEZKewMd%2BG0qxNJiIOM53gR7aXMPhRXXXZ6AQAA&config=H4sIAAAAAAAAA22TTZLjIAyF78I6i6ksetEHmF2fgSIgHLoBuZBI4krl7iMSj42d3qGPZ%2Fnph7v6Jqs%2B72o0haC0E02ZzU19KrDJkC1hZHUQmSBvIsHjoNiUAbhJ6PjneJTriEgwCw4qhRz81JJZTGMBonaWj2qCzLToTCl4XcMTYgST34E2pENmGKCslxZjNCOBvpgNTVJKIMxbVhmcHguOPc4ucMAs4QIdGKcturUYFwpYDhfoRJJHRJnE3hY6ONVhaI2cKVxMrIZXGdyeDZHfLuiMgVj72ll%2Boa3fF9tUG7wuwLWsub4x5K3mB0DMRkOUTYId9zKUPfpFFrKXkfK0UJl35yzDICXqEPxaZ%2FMOhUOXqoCrFlqh9g1uLFNwoMF76XsHr4HtuUvH0wjo11j6ZzoDr1DvdmymbSXe4F8xxv1gZp4Mn%2FeMpnTC%2BJYiAZ%2FRvWFpBuMeFtnn27inNTuQZoPrLip1Yds71ow6tie4dFt2Q77SQ8TTus%2FyVpPJw7KljwbQ1QbuzwY%2BH%2FGHeqyP9v9q0dcsFAM%2FGa9ZPf4B9HvVti4EAAA%3D

Investigation 5

  TRACE  visit_mut_stmt: {
    var e#22;
    return function(n#5) {
        ;
        ;
        return n#5 < n#2 || n#5 > e#2;
    }(r#6) ? r#6 < n#2 ? n#2 : e#2 : r#6;
}

[kdy1]

swc-bump:

• swc_ecma_transforms_optimization

[kdy1]

Skipping the review as this is a very trivial change

[swc-bot]

Automated review comment generated by auto-rebase script