Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Don't break ternary with assignment in test #6906

Merged
merged 7 commits into from Feb 8, 2023
Merged

fix(es/minifier): Don't break ternary with assignment in test #6906

merged 7 commits into from Feb 8, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 5, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 5, 2023
@kdy1 kdy1 self-assigned this Feb 5, 2023
@kdy1 kdy1 mentioned this pull request Feb 5, 2023
Merged
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Don't break ternary expressions with assignment in test Feb 5, 2023
kdy1
kdy1 commented Feb 5, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review February 5, 2023 23:03
@kdy1 kdy1 requested a review from jridgewell February 5, 2023 23:03
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 5, 2023
View reviewed changes
@kdy1 kdy1 changed the title fix(es/minifier): Don't break ternary expressions with assignment in test fix(es/minifier): Don't break ternary with assignment in test Feb 5, 2023
jridgewell
jridgewell previously approved these changes Feb 7, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) February 8, 2023 01:35
@kdy1 kdy1 dismissed stale reviews from jridgewell and kodiakhq via e7c219c February 8, 2023 01:35
@kdy1 kdy1 modified the milestones: Planned, v1.3.33 Feb 8, 2023
@kdy1 kdy1 merged commit 951dafb into swc-project:main Feb 8, 2023
@kdy1 kdy1 deleted the issue-6903 branch February 8, 2023 02:10
@kdy1 kdy1 modified the milestones: v1.3.33, Planned, v1.3.34 Feb 8, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell jridgewell left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.34
Development

Successfully merging this pull request may close these issues.

Unexpected behavior with function redefinition
2 participants
@kdy1 @jridgewell