Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/parser): Fix stack overflow due to deeply nested if #6910

Merged
merged 18 commits into from Feb 7, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 7, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 7, 2023
@kdy1 kdy1 self-assigned this Feb 7, 2023
@kdy1 kdy1 marked this pull request as ready for review February 7, 2023 04:23
@kdy1 kdy1 enabled auto-merge (squash) February 7, 2023 04:23
@kdy1 kdy1 disabled auto-merge February 7, 2023 04:23
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
@kdy1 kdy1 changed the title fix(es/parser): Fix stack overflow due to fix(es/parser): Fix stack overflow due to deeply nested if Feb 7, 2023
@kdy1 kdy1 enabled auto-merge (squash) February 7, 2023 04:24
@kdy1 kdy1 disabled auto-merge February 7, 2023 04:24
@kdy1 kdy1 enabled auto-merge (squash) February 7, 2023 04:24
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge February 7, 2023 12:13
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
@kdy1 kdy1 enabled auto-merge (squash) February 7, 2023 12:29
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 7, 2023
This reverts commit b42972d.
@kdy1 kdy1 merged commit f36d945 into swc-project:main Feb 7, 2023
@kdy1 kdy1 deleted the segfault branch February 7, 2023 14:33
@kdy1 kdy1 modified the milestones: Planned, v1.3.33 Feb 8, 2023
Brooooooklyn added a commit to vercel/turbo that referenced this pull request Feb 8, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.34 Feb 8, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV on extremely nested ifs
2 participants