Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/parser): Add disallow_ambiguous_jsx_like option to parse mts and cts files like tsc and babel #6913

Merged
merged 12 commits into from Mar 3, 2023
Merged

feat(es/parser): Add disallow_ambiguous_jsx_like option to parse mts and cts files like tsc and babel #6913

merged 12 commits into from Mar 3, 2023

Conversation

nissy-dev
Copy link
Contributor

Description: Add disallow_ambiguous_jsx_like option to parse mts and cts files like tsc and babel.

BREAKING CHANGE:

Related issue (if exists): Part of #4679 I also referred to babel/babel#13838

@nissy-dev nissy-dev mentioned this pull request Feb 7, 2023
Merged
@nissy-dev nissy-dev changed the title feat(ec/parser): Add disallow_ambiguous_jsx_like option to parse mts and cts files like tsc and babel feat(es/parser): Add disallow_ambiguous_jsx_like option to parse mts and cts files like tsc and babel Feb 7, 2023
@kdy1 kdy1 marked this pull request as draft February 28, 2023 03:38
@kdy1
Copy link
Member

kdy1 commented Feb 28, 2023

Can you rebase?

@nissy-dev
Copy link
Contributor Author

I rebased!

@kdy1 kdy1 marked this pull request as ready for review March 2, 2023 02:33
@kdy1 kdy1 added this to the Planned milestone Mar 2, 2023
kdy1
kdy1 requested changes Mar 2, 2023
View reviewed changes
crates/swc_ecma_parser/src/lib.rs Outdated Show resolved Hide resolved
nissy-dev and others added 2 commits March 2, 2023 18:31
@nissy-dev @kdy1
Update crates/swc_ecma_parser/src/lib.rs
2620796 
Co-authored-by: Donny/강동윤 <kdy1997.dev@gmail.com>
@nissy-dev
fix: format`
8c93f5f
kdy1
kdy1 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_parser --breaking

@kdy1 kdy1 enabled auto-merge (squash) March 3, 2023 02:00
swc-bot
swc-bot reviewed Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a6471f3 into swc-project:main Mar 3, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.38 Mar 6, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.38
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nissy-dev @kdy1 @swc-bot