Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cargo): bump up swc_css_* #6924

Merged
merged 1 commit into from Feb 10, 2023
Merged

build(cargo): bump up swc_css_* #6924

merged 1 commit into from Feb 10, 2023

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 9, 2023

Description:

Coming from internal report from @jridgewell

swc_css_parser [v0.143.2](https://github.com/swc-project/swc/blob/29fee382249c9b91155d0d3c39d0df82bbd531c1/crates/swc_css_parser/Cargo.toml#L10) has a [js_word!(“first”)](https://github.com/swc-project/swc/blob/29fee382249c9b91155d0d3c39d0df82bbd531c1/crates/swc_css_parser/src/parser/at_rules/mod.rs#L2037)
The swc_css_parser v0.143.2 has a [hard dep](https://github.com/swc-project/swc/blob/29fee382249c9b91155d0d3c39d0df82bbd531c1/crates/swc_css_parser/Cargo.toml#L22) on swc_atoms v0.4.32
swc_atom [0.4.32](https://github.com/swc-project/swc/blob/1161360d5475e82e81aa1179557933d2748ae806/crates/swc_atoms/Cargo.toml#L10) does not include first in its [word list](https://github.com/swc-project/swc/blob/1161360d5475e82e81aa1179557933d2748ae806/crates/swc_atoms/words.txt#L1353-L1356)

BREAKING CHANGE:

Related issue (if exists):

@kwonoj
Copy link
Member Author

kwonoj commented Feb 9, 2023

We may need way to trigger these kind of work automatically from selected users maybe?

jridgewell added a commit to jridgewell/swc-plugins that referenced this pull request Feb 9, 2023
@jridgewell
Pin swc-project/swc#6924
59609b1
jridgewell added a commit to jridgewell/swc-plugins that referenced this pull request Feb 9, 2023
@jridgewell
Pin swc-project/swc#6924
62ca00e
kdy1
kdy1 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_atoms

@kdy1 kdy1 added this to the Planned milestone Feb 10, 2023
@kdy1 kdy1 merged commit 75376cd into swc-project:main Feb 10, 2023
jridgewell added a commit to vercel/turbo that referenced this pull request Feb 10, 2023
@jridgewell
Update swc_core dependencies
1589292 
Resolves a broken `swc_css_parser` fixed in swc-project/swc#6924.
@jridgewell jridgewell mentioned this pull request Feb 10, 2023
Merged
kodiakhq bot pushed a commit to vercel/turbo that referenced this pull request Feb 10, 2023
@jridgewell
Update swc_core dependencies (#3731)
a00b6a3 
Resolves a broken `swc_css_parser` fixed in swc-project/swc#6924.
@kdy1 kdy1 modified the milestones: Planned, v1.3.35 Feb 10, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.35
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @kdy1