fix(es/module): Fix `jsc.paths` on Windows #6930

kdy1 · 2023-02-10T04:55:30Z

Description:

Related issue:

Reverts fix(swc): Remove import statement canonicalization #6716.
Closes Issue with yarn and path building #6782.

kdy1 · 2023-02-10T05:49:41Z

Investigation

From test suite

   INFO  jsc.paths, base_url: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input
    at crates\swc_ecma_loader\src\resolvers\tsc.rs:54
    in Compiler.parse
    in parse_js_as_input
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\config\index.ts)

   INFO  Done in 2.7276ms, kind: "perf"
    at crates\swc_timer\src\lib.rs:32
    in Compiler.parse
    in parse_js_as_input
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\config\index.ts)

  DEBUG  Renaming `config#1` to `config`
    at crates\swc_ecma_transforms_base\src\rename\analyzer\scope.rs:183
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\config\index.ts)

   INFO  Done in 652µs, kind: "perf"
    at crates\swc_timer\src\lib.rs:32
    in Compiler.print
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\config\index.ts)

  DEBUG  compare_to_file: failed to canonicalize outfile path `\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\output\index.map`: Os { code: 2, kind: NotFound, message: "지정된 파일을 찾을 수 없습니다." }
    at crates\testing\src\output.rs:115

File: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts
   INFO  Done in 1.0332ms, kind: "perf"
    at crates\swc_timer\src\lib.rs:32
    in Compiler.parse
    in parse_js_as_input
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

  DEBUG  invoking resolver
    at crates\swc_ecma_transforms_module\src\path.rs:158
    in resolve_import with base: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts, module_specifier: @/config
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

  DEBUG  non-relative import
    at crates\swc_ecma_loader\src\resolvers\tsc.rs:131
    in tsc.resolve with base_url: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input, base: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts, src: @/config
    in resolve_import with base: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts, module_specifier: @/config
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

  TRACE  to_specifier: orig_ext=None
    at crates\swc_ecma_transforms_module\src\path.rs:119
    in resolve_import with base: \\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts, module_specifier: @/config
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

  DEBUG  Renaming `config#3` to `config`
    at crates\swc_ecma_transforms_base\src\rename\analyzer\scope.rs:183
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

  DEBUG  Renaming `main#3` to `main`
    at crates\swc_ecma_transforms_base\src\rename\analyzer\scope.rs:183
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

   INFO  Done in 600.6µs, kind: "perf"
    at crates\swc_timer\src\lib.rs:32
    in Compiler.print
    in process_js_inner
    in process_js_with_custom_pass
    in process_js_file with fm: SourceFile(\\?\C:\Users\MSI\projects\swc-win\crates\swc\tests\fixture\issues-6xxx\6782\1\input\src\index.ts)

base is UNC

Real repo

path is src/index.ts

…t#6716)" This reverts commit b451fa9.

kdy1

swc-bump:

swc

kdy1 · 2023-02-10T09:13:58Z

@realtimetodie Can you send PR for adding tests for #6716? So I can ensure those are working while fixing #6930

realtimetodie · 2023-02-10T21:51:52Z

I can confirm that between b451fa9 and e332dff (now) the module resolution has changed and the previous behavior can no longer be reproduced.

I also confirmed that the Bazel test fails prior to b451fa9 due to path canonicalization

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //examples/paths:test_test
-----------------------------------------------------------------------------
5c5
< const _moduleA = require("../../../../../../../../.cache/bazel/_bazel_kyoko/d981ac4e564436252b4ad023c1ebd769/sandbox/linux-sandbox/35/execroot/aspect_rules_swc/examples/paths/src/modules/moduleA");
---
> const _moduleA = require("./modules/moduleA");
FAIL: files "examples/paths/src/index.js" and "examples/paths/expected.js" differ. 

@//examples/paths:expected.js is out of date. To update this file, run:

    bazel run //examples/paths:test

To confirm this behavior, I created an integration test for Bazel using symbolic links in. The tree is checked out at that fails due to path canonicalization

realtimetodie · 2023-02-10T22:30:16Z

I tested the binary manually with Bazel and the tests pass.

realtimetodie · 2023-02-10T22:31:04Z

@kdy1 I added a Bazel test in realtimetodie@1dc54c8 that verifies symbolic link support.

kdy1 · 2023-02-11T00:14:01Z

@realtimetodie Can you create a PR towards swc main?

realtimetodie · 2023-02-11T11:04:37Z

@kdy1 #6933

kdy1 · 2023-02-11T11:15:50Z

Thank you!

swc-bot

Automated review comment generated by auto-rebase script

kdy1

swc-bump:

swc

kdy1 added 3 commits February 10, 2023 13:52

Add a test

Loading
Loading status checks…

6d626e0

Remove sourcemap

9aa06fb

Update test refs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

9cc76e2

kdy1 added this to the Planned milestone Feb 10, 2023

kdy1 self-assigned this Feb 10, 2023

Remove

93b369a

kdy1 added 2 commits February 10, 2023 14:51

log

29e8a2e

Revert "fix(es): Remove import statement canonicalization (swc-projec…

f74455b

…t#6716)" This reverts commit b451fa9.

kdy1 mentioned this pull request Feb 10, 2023

fix(swc): Remove import statement canonicalization #6716

Merged

Update test refs

Loading
Loading status checks…

7d8bc6a

kdy1 marked this pull request as ready for review February 10, 2023 06:12

kodiakhq bot previously approved these changes Feb 10, 2023

View reviewed changes

kdy1 commented Feb 10, 2023

View reviewed changes

kdy1 changed the title ~~fix(es/module): Fix interop of yarn and jsc.paths on Windows~~ fix(es/module): Fix jsc.paths on Windows Feb 10, 2023

Brooooooklyn mentioned this pull request Feb 10, 2023

@swc-node/register v1.5.6 breaking module aliases transpilation where in v1.5.4 works great swc-project/swc-node#687

Closed

fixup for revert

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

231548c

kdy1 dismissed kodiakhq[bot]’s stale review via 231548c February 10, 2023 09:26

kodiakhq bot approved these changes Feb 10, 2023

View reviewed changes

realtimetodie mentioned this pull request Feb 11, 2023

test(swc): Add Bazel tests #6933

Closed

kdy1 enabled auto-merge (squash) February 11, 2023 15:19

Merge branch 'main' into issue-6782

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

f534ccc

swc-bot reviewed Feb 11, 2023

View reviewed changes

kdy1 commented Feb 11, 2023

View reviewed changes

kdy1 merged commit 1ec161a into swc-project:main Feb 11, 2023

kdy1 deleted the issue-6782 branch February 11, 2023 16:27

kdy1 modified the milestones: Planned, v1.3.36 Feb 21, 2023

titanous mentioned this pull request Feb 21, 2023

chore: update to swc v1.3.36 aspect-build/rules_swc#169

Merged

kabo2468 mentioned this pull request Feb 24, 2023

Windows環境でswcでビルドすると実行できない misskey-dev/misskey#10073

Closed

swc-project locked as resolved and limited conversation to collaborators Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

fix(es/module): Fix `jsc.paths` on Windows #6930

fix(es/module): Fix `jsc.paths` on Windows #6930

kdy1 commented Feb 10, 2023 •

edited

Loading

kdy1 commented Feb 10, 2023 •

edited

Loading

kdy1 left a comment

kdy1 commented Feb 10, 2023

realtimetodie commented Feb 10, 2023

realtimetodie commented Feb 10, 2023

realtimetodie commented Feb 10, 2023

kdy1 commented Feb 11, 2023

realtimetodie commented Feb 11, 2023

kdy1 commented Feb 11, 2023

swc-bot left a comment

kdy1 left a comment

fix(es/module): Fix jsc.paths on Windows #6930

fix(es/module): Fix jsc.paths on Windows #6930

Conversation

kdy1 commented Feb 10, 2023 • edited Loading

kdy1 commented Feb 10, 2023 • edited Loading

Investigation

From test suite

Real repo

kdy1 left a comment

Choose a reason for hiding this comment

kdy1 commented Feb 10, 2023

realtimetodie commented Feb 10, 2023

realtimetodie commented Feb 10, 2023

realtimetodie commented Feb 10, 2023

kdy1 commented Feb 11, 2023

realtimetodie commented Feb 11, 2023

kdy1 commented Feb 11, 2023

swc-bot left a comment

Choose a reason for hiding this comment

kdy1 left a comment

Choose a reason for hiding this comment

fix(es/module): Fix `jsc.paths` on Windows #6930

fix(es/module): Fix `jsc.paths` on Windows #6930

kdy1 commented Feb 10, 2023 •

edited

Loading

kdy1 commented Feb 10, 2023 •

edited

Loading