Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce preAllocation to save memory usage #6979

Merged
merged 1 commit into from Feb 22, 2023
Merged

chore: reduce preAllocation to save memory usage #6979

merged 1 commit into from Feb 22, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Feb 22, 2023 •
edited

Description:

BREAKING CHANGE:

Related issue (if exists):
Closed #6966

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 22, 2023 13:27
kdy1
kdy1 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) February 22, 2023 13:47
@kdy1 kdy1 added this to the Planned milestone Feb 22, 2023
@IWANABETHATGUY
Copy link
Contributor Author

image
The Ci is failed, would you mind rerunning it when you are free, apart from that, I guess this should not related this pr, lol.

@kdy1 kdy1 merged commit f1e7a2a into swc-project:main Feb 22, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the refactor/reduce-pre-alloc branch February 22, 2023 14:44
@kdy1 kdy1 modified the milestones: Planned, v1.3.37 Feb 28, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.37
Development

Successfully merging this pull request may close these issues.

swc_ecma_parser::parse_args memory consumption
2 participants
@IWANABETHATGUY @kdy1