Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(es/parser): Make lexer not generic over Input #6993

Merged
merged 2 commits into from Feb 28, 2023
Merged

refactor(es/parser): Make lexer not generic over Input #6993

merged 2 commits into from Feb 28, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 28, 2023

Description:

Currently, it uses StringInput as the input type, but I'll refactor it to use String or Vec<u8> directly to optimize it further.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 28, 2023
@kdy1 kdy1 self-assigned this Feb 28, 2023
kdy1
kdy1 commented Feb 28, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser --breaking

@kdy1 kdy1 marked this pull request as ready for review February 28, 2023 06:13
@kdy1 kdy1 enabled auto-merge (squash) February 28, 2023 06:13
swc-bot
swc-bot reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge February 28, 2023 07:10
@kdy1 kdy1 enabled auto-merge (squash) February 28, 2023 07:10
@kdy1 kdy1 merged commit 367ac82 into swc-project:main Feb 28, 2023
@kdy1 kdy1 deleted the string-input branch February 28, 2023 08:20
@kdy1 kdy1 modified the milestones: Planned, v1.3.38 Mar 6, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.38
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @swc-bot