Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Fails to parse array spread in TSX props <Foo x={...arr}/> #7011

Merged
merged 5 commits into from Mar 5, 2023
Merged

FIX: Fails to parse array spread in TSX props <Foo x={...arr}/> #7011

merged 5 commits into from Mar 5, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Mar 4, 2023 •
edited

Description:
You could refer to https://github.com/microsoft/TypeScript/blob/43cc362cef72e5fa1372f59736a9c4b55d85def0/src/compiler/parser.ts#L6107-L6133

BREAKING CHANGE:

Related issue (if exists):
Fixed #6977

@IWANABETHATGUY IWANABETHATGUY changed the title chore: 🤖 fix: 6977 FIX: Fails to parse array spread in TSX props <Foo x={...arr}/> Mar 4, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review March 4, 2023 14:23
@kdy1 kdy1 added this to the Planned milestone Mar 5, 2023
kdy1
kdy1 approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

@kdy1 kdy1 enabled auto-merge (squash) March 5, 2023 05:59
swc-bot
swc-bot reviewed Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 6d6731f into swc-project:main Mar 5, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the fix/6977 branch March 5, 2023 09:15
@kdy1 kdy1 modified the milestones: Planned, v1.3.38 Mar 6, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.38
Development

Successfully merging this pull request may close these issues.

Fails to parse array spread in TSX props <Foo x={...arr}/>
4 participants
@IWANABETHATGUY @Brooooooklyn @kdy1 @swc-bot