fix(es/preset-env): update data.rs for core-js3 #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zloirock
reviewed
Mar 6, 2023
| includes: ["es.array.includes", "es.string.includes"], | ||
| indexed: INDEXED, |
There was a problem hiding this comment.
.indexed was removed from the iterators helpers proposal, so it makes no sense to add it.
zloirock
reviewed
Mar 6, 2023
| indexOf: ["es.array.index-of"], | ||
| italics: ["es.string.italics"], | ||
| isWellFormed: ["esnext.string.is-well-formed"], | ||
| italic: ["es.string.italics"], |
zloirock
reviewed
Mar 6, 2023
| import "core-js/modules/es.typed-array.to-string.js"; | ||
| import "core-js/modules/es.typed-array.with.js"; |
There was a problem hiding this comment.
It's strange that it's added here since I see just corejs: 3 without specifying a minor version where those modules were added.
zloirock
reviewed
Mar 7, 2023
| @@ -425,28 +476,33 @@ pub static INSTANCE_PROPERTIES: DataMap<&[&str]> = data_map!(Map { | |||
| getYear: "es.date.get-year", | |||
| groupBy: "esnext.array.group-by", | |||
| groupByToMap: ["esnext.array.group-by-to-map", "es.map", "es.object.to-string"], | |||
| groupToMap:["esnext.array.group-to-map", "es.map", "es.object.to-string"], | |||
zloirock
reviewed
Mar 7, 2023
| trim: ["es.string.trim"], | ||
| trimEnd: ["es.string.trim-end"], | ||
| trimLeft: ["es.string.trim-start"], | ||
| trimRight: ["es.string.trim-end"], | ||
| trimStart: ["es.string.trim-start"], | ||
| uniqueBy: ["esnext.array.unique-by", "es.map"], | ||
| unshift: ["es.array.unshift"], | ||
| unThis: "esnext.function.un-this", | ||
| values: ARRAY_NATURE_ITERATORS_WITH_TAG, | ||
| with: "esnext.array.with", |
zloirock
reviewed
Mar 7, 2023
| toSorted: ["esnext.array.to-sorted", "es.array.sort"], | ||
| toSpliced: "esnext.array.to-spliced", | ||
| toSorted: ["es.array.to-sorted", "es.array.sort"], | ||
| toSpliced: "es.array.to-spliced", |
kdy1
approved these changes
Mar 11, 2023
swc-bot
reviewed
Mar 11, 2023
swc-bot
reviewed
Mar 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I updated data.rs for core-js3 based on https://github.com/babel/babel-polyfills/blob/main/packages/babel-plugin-polyfill-corejs3/src/built-in-definitions.ts
see: #7012 (comment)
BREAKING CHANGE:
Related issue (if exists): #7012