Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctests for swc_ecma_quote #7038

Merged
merged 1 commit into from Mar 9, 2023
Merged

Fix doctests for swc_ecma_quote #7038

merged 1 commit into from Mar 9, 2023

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Mar 9, 2023

Description:

Fix errors from cargo test -p swc_ecma_quote --doc (part of cargo test).

Related issue (if exists):

I suspect this was broken by

although I wonder why this hasn’t been noticed—am I the first to try running cargo test?

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@andersk
Fix doctests for swc_ecma_quote
9991d73 
Fix errors from `cargo test -p swc_ecma_quote --doc` (part of `cargo
test`).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
kdy1
kdy1 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_quote

@kdy1 kdy1 added this to the Planned milestone Mar 9, 2023
@kdy1 kdy1 merged commit e698a34 into swc-project:main Mar 9, 2023
kdy1 pushed a commit to kdy1/swc that referenced this pull request Mar 9, 2023
@andersk @kdy1
test(es/quote): Fix doctests (swc-project#7038)
92f50d0
@andersk andersk deleted the quote-doctests branch March 9, 2023 05:25
@kdy1
Copy link
Member

kdy1 commented Mar 9, 2023

I reverted this as this broke the CI

@kdy1 kdy1 modified the milestones: Planned, v1.3.39 Mar 10, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.39
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @CLAassistant @kdy1