perf(es/lexer): Use jump table for `read_token` #7058

kdy1 · 2023-03-11T11:09:20Z

Description:

kdy1 · 2023-03-11T11:09:40Z

Performance:

Gnuplot not found, using plotters backend
Benchmarking es/parser/colors
Benchmarking es/parser/colors: Warming up for 3.0000 s
Benchmarking es/parser/colors: Collecting 100 samples in estimated 5.0033 s (384k iterations)
Benchmarking es/parser/colors: Analyzing
es/parser/colors        time:   [13.026 us 13.075 us 13.132 us]
                        change: [-15.119% -14.703% -14.309%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  5 (5.00%) high mild
  5 (5.00%) high severe

Benchmarking es/parser/angular
Benchmarking es/parser/angular: Warming up for 3.0000 s
Benchmarking es/parser/angular: Collecting 100 samples in estimated 5.6217 s (800 iterations)
Benchmarking es/parser/angular: Analyzing
es/parser/angular       time:   [6.7509 ms 6.7717 ms 6.7953 ms]
                        change: [-12.015% -11.569% -11.099%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  5 (5.00%) high mild
  10 (10.00%) high severe

Benchmarking es/parser/backbone
Benchmarking es/parser/backbone: Warming up for 3.0000 s
Benchmarking es/parser/backbone: Collecting 100 samples in estimated 9.5340 s (10k iterations)
Benchmarking es/parser/backbone: Analyzing
es/parser/backbone      time:   [935.23 us 937.56 us 940.28 us]
                        change: [-15.091% -14.500% -13.887%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
  7 (7.00%) high mild
  5 (5.00%) high severe

Benchmarking es/parser/jquery
Benchmarking es/parser/jquery: Warming up for 3.0000 s
Benchmarking es/parser/jquery: Collecting 100 samples in estimated 5.2870 s (1000 iterations)
Benchmarking es/parser/jquery: Analyzing
es/parser/jquery        time:   [5.1629 ms 5.1778 ms 5.1942 ms]
                        change: [-15.079% -14.616% -14.187%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  5 (5.00%) high mild
  5 (5.00%) high severe

Benchmarking es/parser/jquery mobile
Benchmarking es/parser/jquery mobile: Warming up for 3.0000 s
Benchmarking es/parser/jquery mobile: Collecting 100 samples in estimated 5.6964 s (700 iterations)
Benchmarking es/parser/jquery mobile: Analyzing
es/parser/jquery mobile time:   [7.8998 ms 7.9282 ms 7.9596 ms]
                        change: [-15.675% -15.200% -14.724%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
  8 (8.00%) high mild
  2 (2.00%) high severe

Benchmarking es/parser/mootools
Benchmarking es/parser/mootools: Warming up for 3.0000 s
Benchmarking es/parser/mootools: Collecting 100 samples in estimated 5.2432 s (1300 iterations)
Benchmarking es/parser/mootools: Analyzing
es/parser/mootools      time:   [3.9448 ms 3.9585 ms 3.9740 ms]
                        change: [-17.959% -17.367% -16.806%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

Benchmarking es/parser/underscore
Benchmarking es/parser/underscore: Warming up for 3.0000 s
Benchmarking es/parser/underscore: Collecting 100 samples in estimated 8.0871 s (10k iterations)
Benchmarking es/parser/underscore: Analyzing
es/parser/underscore    time:   [786.80 us 788.70 us 790.90 us]
                        change: [-17.143% -16.540% -15.954%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  6 (6.00%) high mild
  5 (5.00%) high severe

Benchmarking es/parser/three
Benchmarking es/parser/three: Warming up for 3.0000 s
Benchmarking es/parser/three: Collecting 100 samples in estimated 6.8072 s (300 iterations)
Benchmarking es/parser/three: Analyzing
es/parser/three         time:   [22.124 ms 22.186 ms 22.255 ms]
                        change: [-16.551% -16.003% -15.527%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  5 (5.00%) high mild
  10 (10.00%) high severe

Benchmarking es/parser/yui
Benchmarking es/parser/yui: Warming up for 3.0000 s
Benchmarking es/parser/yui: Collecting 100 samples in estimated 5.2695 s (1300 iterations)
Benchmarking es/parser/yui: Analyzing
es/parser/yui           time:   [3.9702 ms 3.9818 ms 3.9949 ms]
                        change: [-13.089% -12.716% -12.333%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) high mild
  12 (12.00%) high severe

kdy1

swc-bump:

swc_ecma_parser

DanaDane23 · 2023-03-11T11:33:07Z

Noted with thanks

…

On Sat, Mar 11, 2023, 5:09 AM kdy1 ***@***.***> wrote: *Description:* ------------------------------ You can view, comment on, or merge this pull request online at: #7058 Commit Summary - 2a4a390 <2a4a390> Add table.rs - b6a67b5 <b6a67b5> More table - 528344e <528344e> More - 48b3bd7 <48b3bd7> Unicode - a1092c8 <a1092c8> Error - f871e8b <f871e8b> More - 337b634 <337b634> IDT - 3fe7b64 <3fe7b64> More - 2b01bbb <2b01bbb> More - 803220c <803220c> More - 0a3345e <0a3345e> More - f3ae7b7 <f3ae7b7> ^ - a7071b4 <a7071b4> Refactor - 1648622 <1648622> Refactor: `read_token_bang_or_eq` - a37073e <a37073e> More table work - 9140d25 <9140d25> More table work - 057d3f6 <057d3f6> More table work - 5babd45 <5babd45> More table work - cd99346 <cd99346> Table work is done - b0b30e6 <b0b30e6> Fix lexer - dca6944 <dca6944> Fix table - c1a7852 <c1a7852> Use table - 32794e8 <32794e8> Fix table for `@` File Changes (2 files <https://github.com/swc-project/swc/pull/7058/files>) - *M* crates/swc_ecma_parser/src/lexer/mod.rs <https://github.com/swc-project/swc/pull/7058/files#diff-6402bc52db5ddbd503b09a01f2ab9ec09c93953a43f40d641aa0edfa83f0cf08> (254) - *A* crates/swc_ecma_parser/src/lexer/table.rs <https://github.com/swc-project/swc/pull/7058/files#diff-2b4b8a57576cff5f77307802f5134dd5bd022515882a796173a9318c8ee7a17f> (175) Patch Links: - https://github.com/swc-project/swc/pull/7058.patch - https://github.com/swc-project/swc/pull/7058.diff — Reply to this email directly, view it on GitHub <#7058>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6GG5XM6OI5RNFTYAYS5EDLW3RMPJANCNFSM6AAAAAAVXNRBEA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

strager · 2023-03-12T06:40:57Z

crates/swc_ecma_parser/src/lexer/mod.rs

-        match c {
-            None => {}
-            Some(c) => {
-                match c {


I'm curious: Why didn't the Rust compiler make a switch table for this match?

kdy1 added 23 commits March 11, 2023 19:12

Add table.rs

2a4a390

More table

b6a67b5

More

528344e

Unicode

48b3bd7

Error

a1092c8

More

f871e8b

IDT

337b634

More

3fe7b64

More

2b01bbb

More

803220c

More

0a3345e

^

f3ae7b7

Refactor

a7071b4

Refactor: read_token_bang_or_eq

1648622

More table work

a37073e

More table work

9140d25

More table work

057d3f6

More table work

5babd45

Table work is done

cd99346

Fix lexer

b0b30e6

Fix table

dca6944

Use table

c1a7852

Fix table for @

32794e8

kdy1 added this to the Planned milestone Mar 11, 2023

kdy1 self-assigned this Mar 11, 2023

Fix test

a1f9a73

kdy1 marked this pull request as ready for review March 11, 2023 11:28

kdy1 commented Mar 11, 2023

View reviewed changes

kdy1 enabled auto-merge (squash) March 11, 2023 11:28

kodiakhq bot approved these changes Mar 11, 2023

View reviewed changes

Merge branch 'main' into lexer-table

7ef53b7

kdy1 merged commit 9beefaa into swc-project:main Mar 11, 2023

kdy1 deleted the lexer-table branch March 11, 2023 12:13

strager reviewed Mar 12, 2023

View reviewed changes

kdy1 modified the milestones: Planned, v1.3.40 Mar 13, 2023

swc-project locked as resolved and limited conversation to collaborators Apr 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(es/lexer): Use jump table for `read_token` #7058

perf(es/lexer): Use jump table for `read_token` #7058

kdy1 commented Mar 11, 2023

kdy1 commented Mar 11, 2023

kdy1 left a comment •

edited

DanaDane23 commented Mar 11, 2023 via email

strager Mar 12, 2023

perf(es/lexer): Use jump table for read_token #7058

perf(es/lexer): Use jump table for read_token #7058

Conversation

kdy1 commented Mar 11, 2023

kdy1 commented Mar 11, 2023

kdy1 left a comment • edited

Choose a reason for hiding this comment

DanaDane23 commented Mar 11, 2023 via email

strager Mar 12, 2023

Choose a reason for hiding this comment

perf(es/lexer): Use jump table for `read_token` #7058

perf(es/lexer): Use jump table for `read_token` #7058

kdy1 left a comment •

edited