Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/config): respect the value of assumptions #7065

Merged
merged 4 commits into from Mar 13, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari
Copy link
Member Author

magic-akari commented Mar 12, 2023

The test files have been updated as they have enabled the 'loose' mode.
With the 'loose' mode, the 'set_public_class_fields' default value is set to true.

Self {
array_like_is_iterable: true,
constant_reexports: true,
constant_super: true,
enumerable_module_meta: true,
ignore_function_length: true,
ignore_function_name: true,
ignore_to_primitive_hint: true,
iterable_is_array: true,
mutable_template_object: true,
no_class_calls: true,
no_document_all: true,
no_incomplete_ns_import_detection: true,
no_new_arrows: true,
object_rest_no_symbols: true,
private_fields_as_properties: true,
pure_getters: true,
set_class_methods: true,
set_computed_properties: true,
set_public_class_fields: true,
set_spread_properties: true,
skip_for_of_iterator_closing: true,
super_is_callable_constructor: true,
ts_enum_is_readonly: true,
}

@magic-akari magic-akari marked this pull request as ready for review March 12, 2023 13:14
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc

@kdy1 kdy1 enabled auto-merge (squash) March 13, 2023 01:57
@kdy1 kdy1 added this to the Planned milestone Mar 13, 2023
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 self-assigned this Mar 13, 2023
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge March 13, 2023 04:01
@kdy1 kdy1 merged commit 11d4874 into swc-project:main Mar 13, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.40 Mar 13, 2023
@magic-akari magic-akari deleted the fix/assumptions branch March 24, 2023 09:09
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants