Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Insert the variable declaration nearest to the available statements #7067

Merged
merged 1 commit into from Mar 13, 2023
Merged

fix(es/compat): Insert the variable declaration nearest to the available statements #7067

merged 1 commit into from Mar 13, 2023

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Mar 12, 2023 •
edited

@magic-akari magic-akari changed the title fix(es/compat): Insert the variable declaration nearest to the availa… fix(es/compat): Insert the variable declaration nearest to the available statements Mar 12, 2023
@magic-akari
Copy link
Member Author

Furthermore, I believe we should utilize the pure getter of assumption to generate more concise code.
The alias_if_required function can be adapted to accept this parameter.
What are your thoughts on this? @kdy1

@kdy1
Copy link
Member

kdy1 commented Mar 12, 2023

I think it's a good idea

@magic-akari magic-akari marked this pull request as ready for review March 12, 2023 13:07
kdy1
kdy1 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 enabled auto-merge (squash) March 13, 2023 01:56
@kdy1 kdy1 added this to the Planned milestone Mar 13, 2023
@kdy1 kdy1 merged commit ae348e3 into swc-project:main Mar 13, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.40 Mar 13, 2023
@magic-akari magic-akari mentioned this pull request Mar 30, 2023
Closed
@magic-akari magic-akari deleted the fix/issue-7064 branch March 31, 2023 07:08
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.40
Development

Successfully merging this pull request may close these issues.

??= operator in a method retains the lvalue from being GCed in the module global variable
2 participants
@magic-akari @kdy1