fix(cli): Windows stdin handle waits in an infinite loop #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swc-bot
reviewed
Mar 14, 2023
alexeagle
pushed a commit
to realtimetodie/rules_swc
that referenced
this pull request
Mar 20, 2023
It was fixed upstream in swc-project/swc#7077
alexeagle
pushed a commit
to aspect-build/rules_swc
that referenced
this pull request
Mar 20, 2023
It was fixed upstream in swc-project/swc#7077
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the stdin handle from waiting in an infinite loop for the read stream to finish, when running in a process with a detached console on Windows.
This is a known issue on Windows. To prevent this from happening, this change simply flips the order how inputs are parsed. Now, the files option is used first before using the stdin input as a fallback.
As a workaround in Bazel rules_swc, we forward the output of the null device to force the read stream to immediately finish on Windows. However, this workaround appears to cause a difference in argv quoting.
https://github.com/aspect-build/rules_swc/blob/e149dd5fc9e512d5b87b3d52a5aa8422c1a1a309/swc/private/swc.bzl#L194
Related