fix(es/react): align to Babel@8 behavior
#7081
Merged
+376
−541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic-akari
commented
Mar 15, 2023
crates/swc/tests/tsc-references/correctlyMarkAliasAsReferences4.1.normal.js
Show resolved
Hide resolved
kdy1
previously approved these changes
Mar 16, 2023
swc-bot
reviewed
Mar 16, 2023
magic-akari
commented
Mar 16, 2023
| // @babel/plugin-transform-react-jsx: Since "useBuiltIns" is removed in Babel 8, you can remove | ||
| // it from the config. | ||
| #[deprecated( | ||
| note = r#"This is always true. Use swc_ecma_transforms_compat to downlevel JavaScript syntax."# |
There was a problem hiding this comment.
Wait a minute, I should update the comments/
kdy1
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):