fix: accept both keep_fnames and keep_classnames in jsc minify options #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
commented
Mar 16, 2023
| return code; | ||
| } | ||
| await expect(minify()).resolves.toEqual('function Foo() {}\n'); | ||
| }); |
There was a problem hiding this comment.
it seems binding tests is done with published swc_core. I've changed local bindings/binding_core_node/Cargo.toml to point to crates/swc_core to have this test case covered, but the CI might fail because of said reason. Should the Cargo.toml be updated as well?
There was a problem hiding this comment.
great, guess this pr is ready for review now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
att, closes #6996
BREAKING CHANGE:
this change is backward compatible
Related issue (if exists):
#6996