Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod(es/base): Move comments following the order of insertion in fixer #7097

Merged
merged 1 commit into from Mar 20, 2023
Merged

mod(es/base): Move comments following the order of insertion in fixer #7097

merged 1 commit into from Mar 20, 2023

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Mar 19, 2023 •
edited

Description:

Or when encountering nested paren expr with comments, comments would be lost. Found this problem when testing #7096

BREAKING CHANGE:

Related issue (if exists):

kdy1
kdy1 requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_base

crates/swc_ecma_transforms_base/src/fixer.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Mar 20, 2023
kdy1
kdy1 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) March 20, 2023 05:27
@kdy1 kdy1 merged commit f250f24 into swc-project:main Mar 20, 2023
129 checks passed
@Austaras Austaras deleted the paren branch March 20, 2023 06:06
@kdy1 kdy1 modified the milestones: Planned, v1.3.42 Mar 22, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.42
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Austaras @kdy1