Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): minify.{keep_fnames,keep_classnames} should set both compress and mangle #7102

Merged
merged 2 commits into from Mar 21, 2023

Conversation

… compress and mangle

when minify.keep_fnames is true, compressing or mangling of function names should be prevented. same applies to minify.keep_classnames.

- https://github.com/terser/terser#minify-options
@cyjake cyjake changed the title fix(es/minifier): minify.{keep_fnames,keep_classnames} shoud set both compress and mangle fix(es/minifier): minify.{keep_fnames,keep_classnames} should set both compress and mangle Mar 20, 2023
@kdy1 kdy1 added this to the Planned milestone Mar 20, 2023
@kdy1 kdy1 self-assigned this Mar 21, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc

@kdy1 kdy1 enabled auto-merge (squash) March 21, 2023 02:19
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 6a1201c into swc-project:main Mar 21, 2023
130 checks passed
@cyjake cyjake deleted the minify-keep-fnames branch March 21, 2023 04:25
@kdy1 kdy1 modified the milestones: Planned, v1.3.42 Mar 22, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants