fix(es/minifier): minify.{keep_fnames,keep_classnames} should set both compress and mangle #7102
+109
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compress and mangle when minify.keep_fnames is true, compressing or mangling of function names should be prevented. same applies to minify.keep_classnames. - https://github.com/terser/terser#minify-options
cyjake
changed the title
swc-bot
reviewed
Mar 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
when minify.keep_fnames is true, compressing or mangling of function names should be prevented. same applies to minify.keep_classnames.
BREAKING CHANGE:
previously setting either minify.keep_fnames or minify.keep_classnames takes no effect, hence I think this should rather be a bug fix.
Related issue (if exists):