Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/ast): Fix EqIgnoreSpan impl of Number #7112

Merged
merged 5 commits into from Mar 21, 2023
Merged

fix(es/ast): Fix EqIgnoreSpan impl of Number #7112

merged 5 commits into from Mar 21, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 21, 2023

@kdy1 kdy1 added this to the Planned milestone Mar 21, 2023
@kdy1 kdy1 self-assigned this Mar 21, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Remove wrong optimization of ternary with -0 and 0 fix(es/ast): Fix EqIgnoreSpan impl of Number Mar 21, 2023
@kdy1 kdy1 marked this pull request as ready for review March 21, 2023 07:13
@kdy1 kdy1 requested a review from jridgewell March 21, 2023 07:13
kdy1
kdy1 commented Mar 21, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_ast

kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 21, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) March 21, 2023 07:33
swc-bot
swc-bot reviewed Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 6a570a3 into swc-project:main Mar 21, 2023
129 checks passed
@kdy1 kdy1 deleted the issue-7111 branch March 21, 2023 08:46
@kdy1 kdy1 modified the milestones: Planned, v1.3.42 Mar 22, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.42
Development

Successfully merging this pull request may close these issues.

Ternaries with -0 : 0 are removed by compress conditionals
2 participants
@kdy1 @swc-bot