Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/renamer): Don't use symbols used by declarations if eval exists #7116

Merged
merged 14 commits into from Mar 22, 2023
Merged

fix(es/renamer): Don't use symbols used by declarations if eval exists #7116

merged 14 commits into from Mar 22, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 22, 2023

@kdy1 kdy1 added this to the Planned milestone Mar 22, 2023
@kdy1 kdy1 self-assigned this Mar 22, 2023
@kdy1 kdy1 marked this pull request as ready for review March 22, 2023 02:25
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 22, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) March 22, 2023 02:25
kdy1
kdy1 commented Mar 22, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 changed the title fix(es/renamer): Fix handling of eval fix(es/renamer): Avoid symbols used by declarations if eval exists Mar 22, 2023
@kdy1 kdy1 marked this pull request as draft March 22, 2023 02:27
auto-merge was automatically disabled March 22, 2023 02:27

Pull request was converted to draft

@kdy1 kdy1 changed the title fix(es/renamer): Avoid symbols used by declarations if eval exists fix(es/renamer): Don't use symbols used by declarations if eval exists Mar 22, 2023
@kdy1 kdy1 marked this pull request as ready for review March 22, 2023 05:39
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 22, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) March 22, 2023 05:40
swc-bot
swc-bot reviewed Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 6d9763e into swc-project:main Mar 22, 2023
130 checks passed
@kdy1 kdy1 deleted the eval branch March 22, 2023 06:31
@kdy1 kdy1 modified the milestones: Planned, v1.3.43, v1.3.44 Mar 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.44
Development

Successfully merging this pull request may close these issues.

Mangle should respect params usage even there is eval callExpression exist eval breaks async function
2 participants
@kdy1 @swc-bot