feat(es/react): Support script in automatic runtime #7126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Mar 23, 2023
JSerFeng
force-pushed
the
fix/react-require-runtime
branch
4 times, most recently
from
bb8e97a
to
145d357
Compare
JSerFeng
changed the title
JSerFeng
changed the title
jsx-runtime with script source type
kdy1
requested changes
Mar 23, 2023
| init: Some(Box::new(Expr::Call(CallExpr { | ||
| span: DUMMY_SP, | ||
| callee: Callee::Expr(Box::new(Expr::Ident(Ident { | ||
| span: DUMMY_SP, |
There was a problem hiding this comment.
This should have SyntaxContext with unresolve_mark as the only Mark
JSerFeng
force-pushed
the
fix/react-require-runtime
branch
from
145d357
to
ee89b4b
Compare
JSerFeng
force-pushed
the
fix/react-require-runtime
branch
from
ee89b4b
to
6aba7c7
Compare
kdy1
approved these changes
Mar 24, 2023
kdy1
changed the title
jsx-runtime with script source type
kdy1
changed the title
kdy1
changed the title
kdy1
changed the title
swc-bot
reviewed
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Inject
const { jsx: _jsx} = require("react/jsx-runtime")when sourceType isscriptRelated issue: