Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(es/codegen): Extract code from generic functions to reduce compile time #7127

Merged
merged 8 commits into from Mar 23, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 23, 2023

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Mar 23, 2023
@kdy1 kdy1 self-assigned this Mar 23, 2023
@kdy1 kdy1 changed the title refactor(es): Reduce compile time refactor(es/codegen): Reduce compile time Mar 23, 2023
@kdy1 kdy1 marked this pull request as ready for review March 23, 2023 02:33
@kdy1 kdy1 enabled auto-merge (squash) March 23, 2023 02:33
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_ast

@Boshen
Copy link

Boshen commented Mar 23, 2023

Nice work, thank you for working on this! Removing generics will definitely help out.

It would be great if you post your --timings so we can keep a record of improvements from these.

@kdy1 kdy1 disabled auto-merge March 23, 2023 03:39
@kdy1 kdy1 changed the title refactor(es/codegen): Reduce compile time refactor(es/codegen): Extract code from generic functions to reduce compile time Mar 23, 2023
@kdy1 kdy1 enabled auto-merge (squash) March 23, 2023 03:39
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 08fa94f into swc-project:main Mar 23, 2023
129 checks passed
@kdy1 kdy1 deleted the ctime branch March 23, 2023 04:37
@kdy1 kdy1 modified the milestones: Planned, v1.3.43, v1.3.44 Mar 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants