Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): honour import_source in new jsx #7128

Merged
merged 2 commits into from Mar 23, 2023
Merged

fix(react): honour import_source in new jsx #7128

merged 2 commits into from Mar 23, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review March 23, 2023 02:56
kdy1
kdy1 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_transforms_react

@kdy1 kdy1 added this to the Planned milestone Mar 23, 2023
kdy1
kdy1 requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@kdy1 kdy1 enabled auto-merge (squash) March 23, 2023 03:43
@kdy1 kdy1 merged commit 5d7acfd into swc-project:main Mar 23, 2023
129 checks passed
@manucorporat manucorporat mentioned this pull request Mar 23, 2023
Closed
@magic-akari magic-akari deleted the fix/issue-6987 branch March 24, 2023 09:09
@kdy1 kdy1 modified the milestones: Planned, v1.3.43, v1.3.44 Mar 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.44
Development

Successfully merging this pull request may close these issues.

SWC does not honour pragma when spread is used before additional props
2 participants
@magic-akari @kdy1