Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(macros): Reduce compile time #7132

Merged
merged 11 commits into from Mar 23, 2023
Merged

refactor(macros): Reduce compile time #7132

merged 11 commits into from Mar 23, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 23, 2023

Description:

  • Reduce usage of generics in proc-macros.
  • Remove needless operations like parsing tokens as an AST node.

@kdy1 kdy1 added this to the Planned milestone Mar 23, 2023
@kdy1 kdy1 changed the title refactor(macros): Reduce usage of generics to reduce compile time refactor(macros): Reduce compile time Mar 23, 2023
@kdy1
Copy link
Member Author

kdy1 commented Mar 23, 2023

Previous:

   Compiling dbg-swc v0.75.26 (/Users/kdy1/projects/master-swc/crates/dbg-swc)
      Timing report saved to /Users/kdy1/projects/master-swc/target/cargo-timings/cargo-timing-20230323T080509Z.html
    Finished dev [unoptimized + debuginfo] target(s) in 59.17s
(base)

With this PR:

   Compiling dbg-swc v0.75.26 (/Users/kdy1/projects/s/perf/crates/dbg-swc)
      Timing report saved to /Users/kdy1/projects/s/perf/target/cargo-timings/cargo-timing-20230323T080626Z.html
    Finished dev [unoptimized + debuginfo] target(s) in 55.95s
(base)

@kdy1 kdy1 marked this pull request as ready for review March 23, 2023 08:08
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 23, 2023
@kdy1 kdy1 enabled auto-merge (squash) March 23, 2023 08:08
@kdy1 kdy1 disabled auto-merge March 23, 2023 08:08
@kdy1 kdy1 enabled auto-merge (squash) March 23, 2023 08:23
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • ast_node
  • from_variant
  • swc_macros_common
  • testing_macros

Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 disabled auto-merge March 23, 2023 09:16
@kdy1 kdy1 merged commit 2154a3f into swc-project:main Mar 23, 2023
16 checks passed
@kdy1 kdy1 deleted the ctime3 branch March 23, 2023 09:16
@kdy1 kdy1 modified the milestones: Planned, v1.3.43 Mar 29, 2023
@kdy1 kdy1 modified the milestones: v1.3.43, Planned, v1.3.44 Mar 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants