Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fast-graph): Use fxhash instead of ahash to make iteration order consistent #7133

Merged
merged 4 commits into from Mar 23, 2023
Merged

fix(fast-graph): Use fxhash instead of ahash to make iteration order consistent #7133

merged 4 commits into from Mar 23, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 23, 2023 •
edited

Description:

Some operations of petgraph assumes the same iteration order.

@kdy1 kdy1 added this to the Planned milestone Mar 23, 2023
@kdy1 kdy1 self-assigned this Mar 23, 2023
@kdy1 kdy1 marked this pull request as ready for review March 23, 2023 08:47
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 23, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) March 23, 2023 08:47
kdy1
kdy1 commented Mar 23, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_fast_graph

@kdy1 kdy1 disabled auto-merge March 23, 2023 09:28
@kdy1 kdy1 merged commit b13eb4c into swc-project:main Mar 23, 2023
131 checks passed
@kdy1 kdy1 deleted the graph-order branch March 23, 2023 09:32
@kdy1 kdy1 mentioned this pull request Mar 23, 2023
Merged
kdy1 added a commit to dudykr/stc that referenced this pull request Mar 23, 2023
@kdy1
fix: Make evaluation order not flaky (#850)
1424cac 
**Related issue:**

 - swc-project/swc#7133.
@kdy1 kdy1 modified the milestones: Planned, v1.3.43, v1.3.44 Mar 29, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.44
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kdy1